Skip to content

Commit

Permalink
Fixes elastic#3833 make Visualize sidebar collapsible like the one on…
Browse files Browse the repository at this point in the history
… the Discover page
  • Loading branch information
Matt Bargar committed Sep 15, 2015
1 parent e22009b commit d8b0658
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
4 changes: 3 additions & 1 deletion src/plugins/kibana/public/visualize/editor/editor.html
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@

<div class="vis-editor-content">

<vis-editor-sidebar class="vis-editor-sidebar" ng-if="chrome.getVisible()"></vis-editor-sidebar>
<div class="collapsible-sidebar">
<vis-editor-sidebar class="vis-editor-sidebar" ng-if="chrome.getVisible()"></vis-editor-sidebar>
</div>

<div class="vis-editor-canvas" ng-class="{ embedded: !chrome.getVisible() }">
<div class="visualize-info" ng-if="savedVis.id">
Expand Down
1 change: 1 addition & 0 deletions src/plugins/kibana/public/visualize/editor/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ define(function (require) {

require('ui/visualize');
require('ui/clipboard');
require('ui/collapsible_sidebar');

require('ui/routes')
.when('/visualize/create', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@
}
}

&-sidebar {
.collapsible-sidebar {
.flex-parent(0, 0, auto);
}

&-sidebar {
.flex-parent(1, 0, auto);

// overrided for tablet and desktop
@media (min-width: @screen-md-min) {
Expand Down
4 changes: 2 additions & 2 deletions src/ui/public/collapsible_sidebar/collapsible_sidebar.less
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import (reference) "~ui/styles/variables";

.sidebar-container.collapsible-sidebar {
.collapsible-sidebar {
position: relative;
z-index: 1;

Expand Down Expand Up @@ -61,7 +61,7 @@
}

@media (max-width: 992px) {
.sidebar-container.collapsible-sidebar {
.collapsible-sidebar {
&.closed {
display: none;
}
Expand Down

0 comments on commit d8b0658

Please sign in to comment.