Support later versions of Active Support + Ruby 3 #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
Thank you so much for merging #54! It looks like the changes included in that gem release broke our stack though. Would you please consider this fix, which should hopefully support all versions?
Problem
We're running Rails 6 so pinning to
active_support ~> 4.2.7
gives us an incompatible gem issue sinceactive_support
is versioned with Rails (the current version is 7+). Since Rails depends onactive_support
, there is no way to support 4.2.x when Rails requires 6.x (or 7.x in the latest release).Solution
Because the usage of
active_support
in this library is fairly limited, there seems to be no issue supporting later versions. The modifications required are in this PR.I tested this PR on Ruby 2.7.5 and Ruby 3.0.3 and it seems to fix the issues across the board.
Please note that
rexml
is now specified as a dependency. Starting in Ruby 3, it was no longer included as a default gem. So the dependency was always there, but now we need to explicitly pull it in if needed.