Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#86 #87

Closed
wants to merge 4 commits into from
Closed

Feat/#86 #87

wants to merge 4 commits into from

Conversation

cabbage16
Copy link
Member

🎫 κ΄€λ ¨ 이슈

close #86


πŸ“„ κ°œμš”

μž…ν•™μ„€λͺ…νšŒμ— μ‹ μ²­ 링크 μ»¬λŸΌμ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.


πŸ”¨ μž‘μ—… λ‚΄μš©

  • μž…ν•™μ„€λͺ…νšŒ 도메인에 μ‹ μ²­ 링크λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€
  • μˆ˜μ •ν•œ 도메인에 λ”°λΌμ„œ ν…ŒμŠ€νŠΈ μ½”λ“œλ„ μ‹ μ²­ 링크λ₯Ό 보내도둝 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€

🏁 확인 사항

  • ν…ŒμŠ€νŠΈλ₯Ό μ™„λ£Œν–ˆλ‚˜μš”?
  • API λ¬Έμ„œλ₯Ό μž‘μ„±ν–ˆλ‚˜μš”?
  • μ½”λ“œ μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ 둜그, 주석, import 등을 μ‚­μ œν–ˆλ‚˜μš”?

πŸ™‹πŸ» 덧뢙일 말

@cabbage16
feat(#86): μž…ν•™μ„€λͺ…νšŒ 도메인에 applicationUrl 컬럼 μΆ”κ°€
b8512f7
@cabbage16
feat(#86): CreateAdmissionFairUseCase
b617f16 
μž…ν•™μ„€λͺ…νšŒλ₯Ό μ‹ μ²­ν•  λ•Œ dto와 UseCaseμ—μ„œλ„ applicationUrl을 받도둝 μˆ˜μ •
@cabbage16
test(#86): FairFixture, FairControllerTest
2cea7e6 
ν…ŒμŠ€νŠΈμ—μ„œ μž…ν•™μ„€λͺ…νšŒλ₯Ό λ§Œλ“€λ•Œλ„ applicationUrl을 μΆ”κ°€
@cabbage16 cabbage16 requested a review from a team as a code owner June 11, 2024 15:55
@cabbage16 cabbage16 linked an issue Jun 11, 2024 that may be closed by this pull request
[κ°œμ„ ] μž…ν•™μ„€λͺ…νšŒ 도메인 μˆ˜μ • #86
Closed
@github-actions GitHub Actions
Copy link

μ΄λ ‡κ²Œ λ¦¬λ·°ν•΄μ£Όμ„Έμš”.

πŸ–οΈ κ·œμΉ™

  1. μ™œ κ°œμ„ μ΄ ν•„μš”ν•œμ§€ μΆ©λΆ„νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”.
  2. 닡을 μ•Œλ €μ£ΌκΈ°λ³΄λ‹€λŠ” 슀슀둜 κ³ λ―Όν•˜κ³  κ°œμ„  방법을 선택할 수 있게 ν•΄μ£Όμ„Έμš”.
  3. μ½”λ“œλ₯Ό κΉ”λ”ν•˜κ²Œ μœ μ§€ν•˜κ³ , μΌκ΄€λ˜κ²Œ κ΅¬ν˜„ν•˜λ„λ‘ μ•ˆλ‚΄ν•΄ μ£Όμ„Έμš”.
  4. 리뷰 과정이 μˆ™μ œκ²€μ‚¬κ°€ μ•„λ‹Œ ν•™μŠ΅κ³Όμ •μœΌλ‘œ λŠλ‚„ 수 있게 리뷰해 μ£Όμ„Έμš”.
  5. 리뷰λ₯Ό μœ„ν•œ 리뷰λ₯Ό ν•˜μ§€ λ§ˆμ„Έμš”. ν”Όλ“œλ°± ν•  게 μ—†μœΌλ©΄ μΉ­μ°¬ν•΄ μ£Όμ„Έμš”.

πŸ₯¬ μš°μ„ μˆœμœ„

리뷰 μ€‘μš”λ„μ— 따라 λ‹€μŒκ³Ό 같은 prefixλ₯Ό λΆ™μ—¬μ£Όμ„Έμš”.

μ˜ˆμ‹œ - P5) μ“Έλͺ¨μ—†λŠ” 주석 μ‚­μ œν•΄μ£Όμ„Έμš”.

  • P1: κΌ­ λ°˜μ˜ν•΄μ£Όμ„Έμš” (Request changes)
  • P2: 적극적으둜 κ³ λ €ν•΄μ£Όμ„Έμš” (Request changes)
  • P3: μ›¬λ§Œν•˜λ©΄ λ°˜μ˜ν•΄ μ£Όμ„Έμš” (Comment)
  • P4: λ°˜μ˜ν•΄λ„ μ’‹κ³  λ„˜μ–΄κ°€λ„ μ’‹μŠ΅λ‹ˆλ‹€ (Approve)
  • P5: κ·Έλƒ₯ μ‚¬μ†Œν•œ μ˜κ²¬μž…λ‹ˆλ‹€ (Approve)

@cabbage16 cabbage16 self-assigned this Jun 11, 2024
@cabbage16 cabbage16 added the κ°œμ„  μ½”λ“œ λ¦¬νŒ©ν† λ§ label Jun 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cabbage16 cabbage16 closed this Jun 11, 2024
@cabbage16 cabbage16 deleted the feat/#86 branch June 11, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cabbage16 cabbage16

Labels
κ°œμ„  μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[κ°œμ„ ] μž…ν•™μ„€λͺ…νšŒ 도메인 μˆ˜μ •
1 participant
@cabbage16