Bumped protocol version to 1.5.1

This includes the docs submodule which documents the minor API change to *.get_history to support pagination.
BamaHodl · Jun 28, 2023 · d628948 · d628948
1 parent f6543b9
commit d628948
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/doc/electrum-cash-protocol b/doc/electrum-cash-protocol
diff --git a/src/ServerMisc.cpp b/src/ServerMisc.cpp
@@ -4,7 +4,7 @@
 namespace ServerMisc
 {
     const Version MinProtocolVersion(1,4,0);
-    const Version MaxProtocolVersion(1,5,0);
+    const Version MaxProtocolVersion(1,5,1);
     const Version MinTokenAwareProtocolVersion(1,5,0);
     const QString AppVersion(VERSION);
     const QString AppSubVersion = QString("%1 %2").arg(APPNAME, VERSION);

diff --git a/src/Servers.cpp b/src/Servers.cpp
@@ -1530,7 +1530,9 @@ auto Server::parseFromToBlockHeightCommon(const RPC::Message &m) const -> GetHis
         bool ok;
         const int tmp = l[2].toInt(&ok);
         if (ok && tmp > -1) ret.second = static_cast<BlockHeight>(tmp);
-        if (!ok || (ret.second && ret.first > *ret.second))
+        if (!ok
+            || (ret.second && ret.first > *ret.second) /* iff to_height, then from_height <= to_height invariant must hold */
+            || (tmp < 0 && tmp != -1) /* restrict negatives to -1, reject any other negative value */)
             throw RPCError("Bad to_height argument at position 3", RPC::ErrorCodes::Code_InvalidParams);
     }
     return ret;