-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php 8.0 support #23
Php 8.0 support #23
Conversation
Still a major version should be considered because of the implications of updating sentry to 3.x |
As per doctrine/mongodb-odm#2273 we can expect a |
Hi, thanks a lot for your work :) I will try to find some time to review it by the end of this weekend! |
When I wrote the Sentry Middleware, it was not possible to passes an arbitratry PSR request to the Sentry integration, it was always created from superglobals. Now it seems it can be configured with a With RoadRunner we already have a PSR request, it's a waste of time to recreate one from the Symfony one. What do you think if we:
I don't know if this should be a major release or if a |
I think this bundle should remain independent from sentry bundle, not everyone using this bundle will use the sentry bundle, they will have it installed because it is a dependendy but this doesn't mean they will have it enabled (in the same way I have doctrine/mongodb-odm-bundle installed but not enabled). So I think it's better to have independende and recreathe the PSR7 request, it's not that much time, completly neglibible if compared with the real causes of latency in any real web-app, like database queries or any other IO operation. And has the benefit to keeping all core features local to this repository which is easier to test and easier to understand for new people wanting to contribute. A conflict in composer.json would be enought, I didn't think of that. |
I was not proposing to make sentry mandatory here, just clearing a big part of the Howeover it's not a big deal, for the php 8 support I can merge this with a |
Thank you @hugochinchilla :) |
Thanks! Can we have a new release soon? |
I just released 1.4.0. |
Hi, I started working on having php 8.0 compatibility:
replaceddflydev/fig-cookies
withyiisoft/cookies
droppedphp7.3
because ofyiisoft/cookies
dflydev/fig-cookies
to 3.0doctrine/mongodb-odm
instead ofdoctrine/mongodb-odm-bundle
doctrine/mongodb-odm
on a specific commit in master as there is no release withphp8.0
supportsentry/sentry-symfony
updated to 4.0, which causes sentry to update to 3.x, some changes to SentryMiddleware where neededI have tested everything with php 7.4 and 8.0
I think to release this a major version change would be required because of the changes in Sentry and dropping php 7.3