Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I found and fixed a bug regarding ampersand-selectors in _reformat.scss.
Using
&[href^="ftp://"]
on top level is not supposed to work since & is a reference to the parent selector.Both, grunt-sass and node-sass throw the following error when trying to compile that file:
Apparently, for some reason it's okay for gulp-sass, which is why you didn't get an error when compiling the framework.
Further information:
http://thesassway.com/intermediate/referencing-parent-selectors-using-ampersand
EDIT:
you can reproduce this error by running
$ npm i node-sass -g
$ node-sass ./scss/gutenberg.scss .
in the directory root.
I just noticed that this error occurs in utilities.scss aswell. Sorry for the trouble, I added the fix to the pull request