-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework config and save to playlist arg #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2020
Merged
Merged
falkecarlsen
requested changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic stuff, otherwise very nice!
Co-Authored-By: Falke Carlsen <[email protected]>
falkecarlsen
approved these changes
Mar 9, 2020
Badgie
added a commit
that referenced
this pull request
Mar 11, 2020
* Rework config and save to playlist arg (#68) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * Update conf.py Co-Authored-By: Falke Carlsen <[email protected]> * update readme Co-authored-by: Falke Carlsen <[email protected]> * resolve conflicts * resolve conflicts * resolve conflicts * Track feature printing (#75) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * allow printing track features * Enhance tune validation (#74) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * enhance validity check of tunining * add version flag (#61) * remove whitespace error in custom schemes (#62) * Single playlist (#65) * use single playlist * update readme * Add tuning option to print (#67) * add tuning option to print * update readme to reflect install changes * spelling * Catch keyboard interrupts (#60) * catch keyboard interrupts * catch interrupt on new input prompts * add flag for changing playback device (#77) * notify when recommendation yields few different tracks (#78) * fix minor things before release Co-authored-by: Falke Carlsen <[email protected]>
Badgie
added a commit
that referenced
this pull request
Mar 22, 2020
* Version 1.2 (#80) * Rework config and save to playlist arg (#68) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * Update conf.py Co-Authored-By: Falke Carlsen <[email protected]> * update readme Co-authored-by: Falke Carlsen <[email protected]> * resolve conflicts * resolve conflicts * resolve conflicts * Track feature printing (#75) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * allow printing track features * Enhance tune validation (#74) * rework config file & make config-modifying arguments more uniform * add custom config parser * finalize new config structure * clean up conf file and add some print output * allow adding and removing currently playing track to input playlist * update readme * reformat some older functions * minor bug fixes * add and update comments * update intro text in readme * remove redundant non-positional parameter assignments in function calls * enhance validity check of tunining * add version flag (#61) * remove whitespace error in custom schemes (#62) * Single playlist (#65) * use single playlist * update readme * Add tuning option to print (#67) * add tuning option to print * update readme to reflect install changes * spelling * Catch keyboard interrupts (#60) * catch keyboard interrupts * catch interrupt on new input prompts * add flag for changing playback device (#77) * notify when recommendation yields few different tracks (#78) * fix minor things before release Co-authored-by: Falke Carlsen <[email protected]> * fix error with blacklist being generated incorrectly (#81) * add logger class * change info colour * convert print messages * implement switches * add newline to log file print * add shorthands of verbose/quiet * add verbose and debugging prints * use file only with log flag and on crash * update readme * add more comprehensive debugging msgs for requests * add a few debug messages * add more debugs * add log level names for debugging purposes * remove base64 debug Co-authored-by: Falke Carlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to rework the config files as well, so this PR will be a bit more comprehensive than expected.
conf.py
.--[remove|save]-TYPE
scheme.Config structure:
Stuff to fix when merging the remaining PRs: