Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Fix coverage with mixed objc swift project #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Branlute
Copy link

Fix for issue #50 on sonar-swift

Same Pull Request is open on sonar-swift Idean/sonar-swift#88

Change pattern for coverage.xml for avoid conflicts when upload to SonarQube coverage with both plugins Objective-c and swift.

@zippy1978
Copy link

Hi @Branlute,

I dont think it is necessary to rename the coverage report even when using both languages. I think the coverage report is global for the project and not language dependent (but I'm not sure).

Do you have a special case that lead you to do that ?

Regards,
Gilles

@Branlute
Copy link
Author

Branlute commented Dec 6, 2017

Hi @zippy1978 ,

You are right, the coverage report is global, but if SonarQube has both Objective-C and Swift plugins installed, both plugins will try to upload coverage to SonarQube, and SonarQube will only accept one report. So you will have an error.

With this fix, the Objective-c plugin will not upload the coverage generated by swift's script "run-sonar.sh" and vice versa.

Regards,
Thomas

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants