Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker compose repeated anchors fix #2

Merged
merged 1 commit into from
Apr 14, 2023
Merged

docker compose repeated anchors fix #2

merged 1 commit into from
Apr 14, 2023

Conversation

dhananjay12
Copy link
Collaborator

@dhananjay12 dhananjay12 commented Apr 13, 2023

From reported bug

goyaml/v3 does not support repeated anchors (due to internal storage using << as key during parsing) but allows use of multi-values in anchors

While this change is from docker-compose 2.17+ cli, this also works with older version of docker-compose.

I check with my older version of 2.5 and it works. Downside is that although yaml supports this IntelliJ linters shows an error
image
Please give it a try with your existing docker-compose cli version.

@dhananjay12 dhananjay12 requested a review from uesleilima April 13, 2023 20:40
@dhananjay12 dhananjay12 requested a review from a team as a code owner April 13, 2023 20:40
@miladbb
Copy link
Contributor

miladbb commented Apr 14, 2023

From reported bug

goyaml/v3 does not support repeated anchors (due to internal storage using << as key during parsing) but allows use of multi-values in anchors

While this change is from docker-compose 2.17+ cli, this also works with older version of docker-compose.

I check with my older version of 2.5 and it works. Downside is that although yaml supports this IntelliJ linters shows an error image Please give it a try with your existing docker-compose cli version.

Works for me, the version is 2.16.0

@dhananjay12 dhananjay12 merged commit b9b40c4 into main Apr 14, 2023
@dhananjay12 dhananjay12 deleted the BEFOUND-1044 branch April 14, 2023 08:48
@uesleilima
Copy link
Contributor

#3 will fix the IntelliJ ide issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants