-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to specify diff file location #410
Added option to specify diff file location #410
Conversation
Neat, thanks for the PR. to merge this ill. need tests. I also think the file tool is strongly dependent on the diff format diff-cover uses. So some documentation on how to generate the diff file in the readme would be nice. |
No problem. And okay sure thing. Thanks for the quick reply! |
@Bachmann1234 Have added documentation and 4 UT for the diff file tool |
@Jsostmann looks like you just have to run black over the pr to format things. Then this is looking good! Thanks! |
Awesome! and Thanks I'll go ahead and reformat using black. |
Ah jeez. My bad. I forgot to mention |
Haha no worries! I should've caught that also. I didn't run verify.sh before pushing |
Awesome. Build is passing I should be able to get this merged and released soon. Hoping for tonight |
Great! No rush, I appreciate the help! |
Thanks a lot @Jsostmann for the feature and @Bachmann1234 for your great work on this most helpful project! |
Alrighty, lets get this merged. Thanks for the PR @Jsostmann ! |
Check out version 9.1.0! https://pypi.org/project/diff-cover/9.1.0/ thanks again |
Sure thing! Hope it helps! |
Awesome! Sure thing! |
@Jsostmann May I ask if there is validation for diff file=diff. txt to support Jacoco generated XML full coverage reports? I recently encountered an issue while generating incremental reports based on multiple XML full coverage reports in a Java project. |
Hey @chkch did you check to make sure that the diff file you created had any changes? |
Added a flag to accept a path which points to a file containing the output of
git diff
ex:
diff-cover coverage_folder/coverage.xml --html-report report.html --diff-file=diff.txt