Python script for Changelog auto-completion #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Github. - Changelog : Last version date added (needed for auto completion) - Readme : Explaination added - BabylonExporter.cs : Version number incremented by 0.1 for testing purpose
Drigax
suggested changes
Jun 5, 2019
There was a problem hiding this comment.
Where do we expect our users to execute this script from?
I see that we're using pathing from the 3dsMax solution folder root to the Exporter/BabylonExporter file to detect our new version number, but I originally wrote this to path from the Max2Babylon project folder root containing the script. Not a huge problem, but just want to make sure that this works as expected and is documented as such.
Drigax
suggested changes
Jun 5, 2019
…PI Key // Modification of the path
|
This should be good ! |
|
Thanks, looks great! Checking in. |
Drigax
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python script for Changelog auto-completion, retrieving datas from the Github.