Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native 0.71 support #556

Merged
merged 58 commits into from
Mar 10, 2023
Merged
Show file tree
Hide file tree
Changes from 55 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
a3f16ce
generated PG
CedricGuillemetMS Feb 20, 2023
adc20a8
doc changes
CedricGuillemetMS Feb 20, 2023
0d5d6d4
jobs
CedricGuillemetMS Feb 20, 2023
4b37d93
missing jobs
CedricGuillemetMS Feb 20, 2023
87f702b
fix legacy deps
CedricGuillemetMS Feb 20, 2023
dfb5ad5
removed yarn.lock
CedricGuillemetMS Feb 20, 2023
a829abf
deps update
CedricGuillemetMS Feb 20, 2023
d80d1d5
node option for windows build
CedricGuillemetMS Feb 20, 2023
4b47366
another test at options for node18
CedricGuillemetMS Feb 20, 2023
c96c2ce
another test at node flags
CedricGuillemetMS Feb 20, 2023
f69b4d4
windows autolink
CedricGuillemetMS Feb 20, 2023
8ac9782
version string
CedricGuillemetMS Feb 20, 2023
2819b17
test with rn 0.69
CedricGuillemetMS Feb 20, 2023
f66d00a
turbomodule
CedricGuillemetMS Feb 23, 2023
3705bf2
turbomodule
CedricGuillemetMS Feb 23, 2023
e8b33a0
cppwinrt pckg
CedricGuillemetMS Feb 23, 2023
0860879
test with more recent dep
CedricGuillemetMS Feb 23, 2023
0f9ed8e
turbomodule binary dir
CedricGuillemetMS Feb 23, 2023
d33cc6f
nodejs 16 for Windows build matrix
CedricGuillemetMS Feb 23, 2023
32ea85c
node+vcproj
CedricGuillemetMS Feb 23, 2023
9512a3c
winrt
CedricGuillemetMS Feb 24, 2023
e9f8be7
node 14
CedricGuillemetMS Feb 24, 2023
166ebba
back to node 16
CedricGuillemetMS Feb 24, 2023
4e27ad5
removed node18 flag
CedricGuillemetMS Feb 24, 2023
197e6ef
builds are back
CedricGuillemetMS Feb 24, 2023
9012b22
will stick to 0.64 for PR
CedricGuillemetMS Feb 24, 2023
7b62dd8
cmake fixes
CedricGuillemetMS Feb 27, 2023
982a4a9
yml typo
CedricGuillemetMS Feb 27, 2023
4c885e3
call invoker
CedricGuillemetMS Feb 27, 2023
8cdd2e4
more include dirs
CedricGuillemetMS Feb 27, 2023
cba2596
more paths
CedricGuillemetMS Feb 27, 2023
4f275bd
react native version
CedricGuillemetMS Feb 27, 2023
88277b4
back to 0.71.1
CedricGuillemetMS Feb 27, 2023
99e9e45
0.70.0
CedricGuillemetMS Feb 27, 2023
8c9a66d
yet another test
CedricGuillemetMS Feb 27, 2023
36b994a
revert changes for node 18
CedricGuillemetMS Feb 28, 2023
d59afa8
removed folly runtime test
CedricGuillemetMS Feb 28, 2023
cf314e7
up RN 0.71.3
CedricGuillemetMS Feb 28, 2023
204b8db
prefabs
CedricGuillemetMS Mar 1, 2023
ac713ee
RN 0.71.1
CedricGuillemetMS Mar 1, 2023
c373266
another test at hermes
CedricGuillemetMS Mar 1, 2023
aa2cc97
0.71 android build
CedricGuillemet Mar 2, 2023
9aa1166
lib for < 0.71
CedricGuillemet Mar 2, 2023
ba299c6
fix cmake, shared c++
CedricGuillemet Mar 3, 2023
c539ccc
Merge branch 'master' into RN071
CedricGuillemet Mar 3, 2023
98567ba
patched json
CedricGuillemet Mar 3, 2023
d9cc125
c++ shared
CedricGuillemet Mar 3, 2023
15c7ec6
RN gulp diff
CedricGuillemet Mar 3, 2023
009277d
deprecated gradle method
CedricGuillemet Mar 3, 2023
d214fee
deprecated gradle method 2
CedricGuillemet Mar 3, 2023
7149df0
build again...
CedricGuillemet Mar 5, 2023
0279704
Merge branch 'master' into RN071
CedricGuillemet Mar 5, 2023
1540e44
up ndk version
CedricGuillemet Mar 7, 2023
49e3354
ndk 23.1.7779620
CedricGuillemet Mar 7, 2023
4a44887
disable nativecamera for testing
CedricGuillemet Mar 7, 2023
66ebb9e
Merge branch 'master' of https://github.com/BabylonJS/BabylonReactNat…
CedricGuillemet Mar 10, 2023
7a1ad12
put back nativecamera in
CedricGuillemet Mar 10, 2023
73f99c6
missing windows
CedricGuillemet Mar 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 13 additions & 61 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- master
env:
BRN_Version: 0.64
BRN_Version: '0.64'

jobs:
build-android:
Expand Down Expand Up @@ -160,6 +160,12 @@ jobs:
react-native-version: '0.70'
release-version: 0.0.${GITHUB_SHA::8}

build-android-ios-071:
uses: ./.github/workflows/ios_android.yml
with:
react-native-version: '0.71'
release-version: 0.0.${GITHUB_SHA::8}

build-windows-065:
uses: ./.github/workflows/windows.yml
with:
Expand All @@ -178,67 +184,13 @@ jobs:
react-native-version: '0.70'
release-version: 0.0.${GITHUB_SHA::8}

build-windows-071:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.71'
release-version: 0.0.${GITHUB_SHA::8}

build-typescript:
uses: ./.github/workflows/typescript.yml
with:
release-version: 0.0.${GITHUB_SHA::8}

# package:
# needs: [build-typescript, build-android-ios-065, build-windows-065]
# runs-on: ubuntu-latest
# steps:
## Download artifacts
# - name: Download Assembled Folder
# uses: actions/download-artifact@v2
# with:
# name: 'Assembled'
# path: Package/Assembled
# - name: Download Assembled-iOSAndroid 0.65 Folder
# uses: actions/download-artifact@v2
# with:
# name: 'Assembled-iOSAndroid0.65'
# path: Package/Assembled-iOSAndroid0.65
# - name: Download Assembled-Windows 0.65 Folder
# uses: actions/download-artifact@v2
# with:
# name: 'Assembled-Windows0.65'
# path: Package/Assembled-Windows0.65
## Set up node js
# - name: Setup Node.js
# uses: actions/[email protected]
# with:
# node-version: '12.x'
# registry-url: 'https://npm.pkg.github.com'
## Publish
# - name: Version & Publish Package @babylonjs/react-native
# run: |
# npm version --no-git-tag-version 0.0.0-${GITHUB_SHA::8}
# npm publish --access public --verbose
# working-directory: ./Package/Assembled
# env:
# NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
#
# - name: Version & Publish Package @babylonjs/react-native-iosandroid-0-65
# run: |
# npm version --no-git-tag-version 0.0.0-${GITHUB_SHA::8}
# npm publish
# working-directory: ./Package/Assembled-iOSAndroid0.65
# env:
# NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
#
# - name: Version & Publish Package @babylonjs/react-native-windows-0-65
# run: |
# npm version --no-git-tag-version 0.0.0-${GITHUB_SHA::8}
# npm publish
# working-directory: ./Package/Assembled-Windows0.65
# env:
# NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
## Add PR comment with packages version
# - name: Add SHORT_SHA env property with commit short sha
# run: echo "SHORT_SHA=`echo ${GITHUB_SHA::8}`" >> $GITHUB_ENV
# - name: Comment PR
# uses: thollander/actions-comment-pull-request@v1
# with:
# message: |
# Package available on https://npm.pkg.github.com registry. Packages version is 0.0.0-${{ env.SHORT_SHA }} . Packages list : https://github.com/BabylonJS/BabylonReactNative/packages
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
40 changes: 38 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ jobs:
react-native-version: '0.70'
release-version: ${GITHUB_REF/refs\/tags\//}

build-android-ios-071:
uses: ./.github/workflows/ios_android.yml
with:
react-native-version: '0.71'
release-version: ${GITHUB_REF/refs\/tags\//}

build-windows-064:
uses: ./.github/workflows/windows.yml
with:
Expand All @@ -52,13 +58,19 @@ jobs:
react-native-version: '0.70'
release-version: ${GITHUB_REF/refs\/tags\//}

build-windows-071:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.71'
release-version: ${GITHUB_REF/refs\/tags\//}

build-typescript:
uses: ./.github/workflows/typescript.yml
with:
release-version: ${GITHUB_REF/refs\/tags\//}

package:
needs: [build-typescript, build-android-ios-064, build-android-ios-065, build-android-ios-069, build-android-ios-070, build-windows-064, build-windows-065, build-windows-069, build-windows-070]
needs: [build-typescript, build-android-ios-064, build-android-ios-065, build-android-ios-069, build-android-ios-070, build-android-ios-071, build-windows-064, build-windows-065, build-windows-069, build-windows-070, build-windows-071]
runs-on: macos-latest
steps:
- name: Checkout Repo
Expand Down Expand Up @@ -91,6 +103,11 @@ jobs:
with:
name: 'Assembled-iOSAndroid0.70'
path: Package/Assembled-iOSAndroid0.70
- name: Download Assembled-iOSAndroid 0.71 Folder
uses: actions/download-artifact@v2
with:
name: 'Assembled-iOSAndroid0.71'
path: Package/Assembled-iOSAndroid0.71
- name: Download Assembled-Windows 0.64 Folder
uses: actions/download-artifact@v2
with:
Expand All @@ -111,6 +128,11 @@ jobs:
with:
name: 'Assembled-Windows0.70'
path: Package/Assembled-Windows0.70
- name: Download Assembled-Windows 0.71 Folder
uses: actions/download-artifact@v2
with:
name: 'Assembled-Windows0.71'
path: Package/Assembled-Windows0.71
- name: Display structure of downloaded Assembled and Assembled-Windows folders
run: ls -R
- name: Setup Node.js
Expand Down Expand Up @@ -155,6 +177,13 @@ jobs:
working-directory: ./Package/Assembled-iOSAndroid0.70
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Version & Publish Package @babylonjs/react-native-iosandroid-0-71
run: |
npm version --no-git-tag-version ${GITHUB_REF/refs\/tags\//}
npm publish --access public
working-directory: ./Package/Assembled-iOSAndroid0.71
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Version & Publish Package @babylonjs/react-native-windows-0-64
run: |
Expand Down Expand Up @@ -183,4 +212,11 @@ jobs:
npm publish --access public
working-directory: ./Package/Assembled-Windows0.70
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Version & Publish Package @babylonjs/react-native-windows-0-71
run: |
npm version --no-git-tag-version ${GITHUB_REF/refs\/tags\//}
npm publish --access public
working-directory: ./Package/Assembled-Windows0.71
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
38 changes: 37 additions & 1 deletion .github/workflows/publish_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ jobs:
react-native-version: '0.70'
release-version: ${{ github.event.inputs.release_version }}

build-android-ios-071:
uses: ./.github/workflows/ios_android.yml
with:
react-native-version: '0.71'
release-version: ${{ github.event.inputs.release_version }}

build-windows-064:
uses: ./.github/workflows/windows.yml
with:
Expand All @@ -62,6 +68,12 @@ jobs:
react-native-version: '0.70'
release-version: ${{ github.event.inputs.release_version }}

build-windows-071:
uses: ./.github/workflows/windows.yml
with:
react-native-version: '0.71'
release-version: ${{ github.event.inputs.release_version }}

build-typescript:
uses: ./.github/workflows/typescript.yml
with:
Expand Down Expand Up @@ -101,6 +113,11 @@ jobs:
with:
name: 'Assembled-iOSAndroid0.70'
path: Package/Assembled-iOSAndroid0.70
- name: Download Assembled-iOSAndroid 0.71 Folder
uses: actions/download-artifact@v2
with:
name: 'Assembled-iOSAndroid0.71'
path: Package/Assembled-iOSAndroid0.71
- name: Download Assembled-Windows 0.64 Folder
uses: actions/download-artifact@v2
with:
Expand All @@ -121,6 +138,11 @@ jobs:
with:
name: 'Assembled-Windows0.70'
path: Package/Assembled-Windows0.70
- name: Download Assembled-Windows 0.71 Folder
uses: actions/download-artifact@v2
with:
name: 'Assembled-Windows0.71'
path: Package/Assembled-Windows0.71
- name: Display structure of downloaded Assembled and Assembled-Windows folders
run: ls -R
- name: Setup Node.js
Expand Down Expand Up @@ -165,6 +187,13 @@ jobs:
working-directory: ./Package/Assembled-iOSAndroid0.70
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Version & Publish Package @babylonjs/react-native-iosandroid-0-71
run: |
npm version --no-git-tag-version ${{ github.event.inputs.release_version }}
npm publish --access public --tag ${{ github.event.inputs.NPM_tag }}
working-directory: ./Package/Assembled-iOSAndroid0.71
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Version & Publish Package @babylonjs/react-native-windows-0-64
run: |
Expand Down Expand Up @@ -193,4 +222,11 @@ jobs:
npm publish --access public --tag ${{ github.event.inputs.NPM_tag }}
working-directory: ./Package/Assembled-Windows0.70
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Version & Publish Package @babylonjs/react-native-windows-0-71
run: |
npm version --no-git-tag-version ${{ github.event.inputs.release_version }}
npm publish --access public --tag ${{ github.event.inputs.NPM_tag }}
working-directory: ./Package/Assembled-Windows0.71
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
2 changes: 2 additions & 0 deletions Apps/Playground/0.71/.bundle/config
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
BUNDLE_PATH: "vendor/bundle"
BUNDLE_FORCE_RUBY_PLATFORM: 1
4 changes: 4 additions & 0 deletions Apps/Playground/0.71/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
root: true,
extends: '@react-native-community',
};
63 changes: 63 additions & 0 deletions Apps/Playground/0.71/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
# OSX
#
.DS_Store

# Xcode
#
build/
*.pbxuser
!default.pbxuser
*.mode1v3
!default.mode1v3
*.mode2v3
!default.mode2v3
*.perspectivev3
!default.perspectivev3
xcuserdata
*.xccheckout
*.moved-aside
DerivedData
*.hmap
*.ipa
*.xcuserstate
ios/.xcode.env.local

# Android/IntelliJ
#
build/
.idea
.gradle
local.properties
*.iml
*.hprof
.cxx/
*.keystore
!debug.keystore

# node.js
#
node_modules/
npm-debug.log
yarn-error.log

# fastlane
#
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
# screenshots whenever they are needed.
# For more information about the recommended setup visit:
# https://docs.fastlane.tools/best-practices/source-control/

**/fastlane/report.xml
**/fastlane/Preview.html
**/fastlane/screenshots
**/fastlane/test_output

# Bundle artifact
*.jsbundle

# Ruby / CocoaPods
/ios/Pods/
/vendor/bundle/

# Temporary files created by Metro to check the health of the file watcher
.metro-health-check*
1 change: 1 addition & 0 deletions Apps/Playground/0.71/.node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16
7 changes: 7 additions & 0 deletions Apps/Playground/0.71/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = {
arrowParens: 'avoid',
bracketSameLine: true,
bracketSpacing: false,
singleQuote: true,
trailingComma: 'all',
};
1 change: 1 addition & 0 deletions Apps/Playground/0.71/.ruby-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.7.6
1 change: 1 addition & 0 deletions Apps/Playground/0.71/.watchmanconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
6 changes: 6 additions & 0 deletions Apps/Playground/0.71/Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
source 'https://rubygems.org'

# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
ruby File.read(File.join(__dir__, '.ruby-version')).strip

gem 'cocoapods', '~> 1.11', '>= 1.11.3'
14 changes: 14 additions & 0 deletions Apps/Playground/0.71/__tests__/App-test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/**
* @format
*/

import 'react-native';
import React from 'react';
import App from '../App';

// Note: test renderer must be required after react-native.
import renderer from 'react-test-renderer';

it('renders correctly', () => {
renderer.create(<App />);
});
Loading