Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morph targets are broken #923

Closed
bghgary opened this issue Oct 19, 2021 · 4 comments · Fixed by #986, #998 or #1009
Closed

Morph targets are broken #923

bghgary opened this issue Oct 19, 2021 · 4 comments · Fixed by #986, #998 or #1009
Assignees
@SergioRZMasson

Comments

@bghgary
Copy link
Contributor

bghgary commented Oct 19, 2021

Steps to reproduce the behavior:

  1. Open any model that uses morph targets (e.g., MorphPrimitivesTest)

Result: Error in JS: Unable to get property 'TEXTURE_2D_ARRAY' of undefined or null reference

Expected behavior
Model to load without error
@bghgary
Copy link
Contributor Author

bghgary commented Oct 19, 2021

Work around: put this somewhere before loading a model.

BABYLON.MorphTargetManager.EnableTextureStorage = false;

@bghgary
Copy link
Contributor Author

bghgary commented Oct 19, 2021

Once fixed, we should add validation tests so that this doesn't break again.

@bghgary bghgary mentioned this issue Dec 1, 2021
Closed
SergioRZMasson added a commit that referenced this issue Jan 26, 2022
@SergioRZMasson @bghgary
Fixed issue #923 by implementing 2D Texture Array to be used with Mor…
5b5ad20 
…ph targets. (#981)

* Added support for Morph targets to use 2D texture arrays. Added check for uniforms array length to avoid memory overrun

* Code cleanup, moved array lenght check to after the null check

* Update Plugins/NativeEngine/Source/NativeEngine.h

Co-authored-by: Gary Hsu <[email protected]>

* Update Plugins/NativeEngine/Source/NativeEngine.cpp

Co-authored-by: Gary Hsu <[email protected]>

* Moved element size info to Babylon::UniformInfo. Changed business logic to allow usage of UniformInfo for size check at runtime

* Revert "Moved element size info to Babylon::UniformInfo. Changed business logic to allow usage of UniformInfo for size check at runtime"

This reverts commit 117c2e6.

* Reimplemented changes after reversing clang-format changes

* Cleanup unused parameters and added exception for not supported ones

* Update Plugins/NativeEngine/Source/NativeEngine.cpp

Co-authored-by: Gary Hsu <[email protected]>

Co-authored-by: Gary Hsu <[email protected]>
@SergioRZMasson SergioRZMasson linked a pull request Jan 27, 2022 that will close this issue
Updated npm package to latest version of babylonjs, fixed texture flag bug on 2D Texture arrays #986
Merged
@SergioRZMasson SergioRZMasson mentioned this issue Jan 27, 2022
Merged
@bghgary
Copy link
Contributor Author

bghgary commented Feb 4, 2022

Once fixed, we should add validation tests so that this doesn't break again.

@SergioRZMasson I think we missed doing this. It would be good to do so that we can't break it again.

@SergioRZMasson SergioRZMasson mentioned this issue Feb 11, 2022
Merged
@bghgary
Copy link
Contributor Author

bghgary commented Feb 17, 2022

Turns out, morph targets are still not working properly.

@bghgary bghgary reopened this Feb 17, 2022
@bghgary bghgary removed their assignment Feb 18, 2022
@SergioRZMasson SergioRZMasson mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergioRZMasson SergioRZMasson

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bghgary @SergioRZMasson