-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calculated tangent when using right handed system #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardWolosky
added a commit
to HowardWolosky/gltf-vscode
that referenced
this pull request
Jun 2, 2017
…changes * Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`. * Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222). * Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7). Resolves Issue AnalyticalGraphicsInc#15 > **Work in Progress** > - This doesn't have a Babylon with pull 2222 since that hasn't been taken to master > - Active preview for Babylon is not currently working for some reason. More investgiation needs to happen.
13 tasks
HowardWolosky
added a commit
to HowardWolosky/gltf-vscode
that referenced
this pull request
Jun 5, 2017
…changes * Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`. * Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222). * Babylon (like Cesium) now defaults to previewing the content in the tab as opposed to the content saved in the file, the same way it's done in this [Babylon Plaground Example](https://www.babylonjs-playground.com/#1AbIIF#7). Resolves Issue AnalyticalGraphicsInc#15 > **Work in Progress** > - Active preview for Babylon is not currently working for some reason. More investgiation needs to happen.
HowardWolosky
added a commit
to HowardWolosky/gltf-vscode
that referenced
this pull request
Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`. * Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222). Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky
added a commit
to HowardWolosky/gltf-vscode
that referenced
this pull request
Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`. * Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222). Resolves Issue AnalyticalGraphicsInc#15
HowardWolosky
added a commit
to HowardWolosky/gltf-vscode
that referenced
this pull request
Jun 5, 2017
* Updated Cesium engine to 1.34 and leveraged the new [`basepath`](CesiumGS/cesium#5320) option in `Cesium.Model.fromGltf`. * Updated Babylon.js engine to get a [tangent fix](BabylonJS/Babylon.js#2222). Resolves Issue AnalyticalGraphicsInc#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.