Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardMaterial: remove _worldViewProjectionMatrix #16071

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

kzhsw
Copy link
Contributor

@kzhsw kzhsw commented Jan 16, 2025

It's not found elsewhere in this repo, removing it to save some memory.

Forum link: https://forum.babylonjs.com/t/standardmaterial-is-worldviewprojectionmatrix-still-in-use/55971

If I understand correctly, changelog should be auto generated from this PR, right?

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) January 16, 2025 00:25
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

auto-merge was automatically disabled January 16, 2025 00:42

Head branch was pushed to by a user without write access

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@deltakosh deltakosh added the bug label Jan 16, 2025
@deltakosh
Copy link
Contributor

If I understand correctly, changelog should be auto generated from this PR, right?

Absolutely!

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@sebavan sebavan merged commit f8fdf26 into BabylonJS:master Jan 16, 2025
14 checks passed
@kzhsw kzhsw deleted the patch-1 branch January 16, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants