Tensor: Standardize Vector2, Vector3, Vector4, Color3, Color4, Quaternion, and Matrix

packages/dev/core/src/Actions/action.ts

@@ -309,12 +309,12 @@ export class Action implements IAction {
             targetType: (<Mesh>target)._isMesh
                 ? "MeshProperties"
                 : (<Light>target)._isLight
-                  ? "LightProperties"
-                  : (<Camera>target)._isCamera
-                    ? "CameraProperties"
-                    : (<Material>target)._isMaterial
-                      ? "MaterialProperties"
-                      : "SceneProperties",
+                ? "LightProperties"
+                : (<Camera>target)._isCamera
+                ? "CameraProperties"
+                : (<Material>target)._isMaterial
+                ? "MaterialProperties"
+                : "SceneProperties",
             value: (<Scene>target)._isScene ? "Scene" : (<Node>target).name,
         };
     };

packages/dev/core/src/Bones/skeleton.ts

@@ -751,8 +751,8 @@ export class Skeleton implements IAnimatable {
                 index: bone.getIndex(),
                 name: bone.name,
                 id: bone.id,
-                matrix: bone.getBindMatrix().toArray(),
-                rest: bone.getRestMatrix().toArray(),
+                matrix: bone.getBindMatrix().asArray(),
+                rest: bone.getRestMatrix().asArray(),
                 linkedTransformNodeId: bone.getTransformNode()?.id,
             };
 

packages/dev/core/src/Cameras/Inputs/freeCameraDeviceOrientationInput.ts

@@ -173,8 +173,8 @@ export class FreeCameraDeviceOrientationInput implements ICameraInput<FreeCamera
             <any>window.orientation !== undefined
                 ? +(<any>window.orientation)
                 : (<any>window.screen).orientation && (<any>window.screen).orientation["angle"]
-                  ? (<any>window.screen).orientation.angle
-                  : 0;
+                ? (<any>window.screen).orientation.angle
+                : 0;
         this._screenOrientationAngle = -Tools.ToRadians(this._screenOrientationAngle / 2);
         this._screenQuaternion.copyFromFloats(0, Math.sin(this._screenOrientationAngle), 0, Math.cos(this._screenOrientationAngle));
     };

packages/dev/core/src/Cameras/camera.ts

@@ -2,7 +2,7 @@ import { serialize, SerializationHelper, serializeAsVector3 } from "../Misc/deco
 import { SmartArray } from "../Misc/smartArray";
 import { Tools } from "../Misc/tools";
 import { Observable } from "../Misc/observable";
-import type { Nullable } from "../types";
+import type { DeepImmutable, Nullable } from "../types";
 import type { CameraInputsManager } from "./cameraInputsManager";
 import type { Scene } from "../scene";
 import { Matrix, Vector3, Quaternion } from "../Maths/math.vector";
@@ -1401,7 +1401,7 @@ export class Camera extends Node {
      * @param localAxis Defines the reference axis to provide a relative direction.
      * @returns the direction
      */
-    public getDirection(localAxis: Vector3): Vector3 {
+    public getDirection(localAxis: DeepImmutable<Vector3>): Vector3 {
         const result = Vector3.Zero();
 
         this.getDirectionToRef(localAxis, result);
@@ -1423,7 +1423,7 @@ export class Camera extends Node {
      * @param localAxis Defines the reference axis to provide a relative direction.
      * @param result Defines the vector to store the result in
      */
-    public getDirectionToRef(localAxis: Vector3, result: Vector3): void {
+    public getDirectionToRef(localAxis: DeepImmutable<Vector3>, result: Vector3): void {
         Vector3.TransformNormalToRef(localAxis, this.getWorldMatrix(), result);
     }
 

packages/dev/core/src/Debug/directionalLightFrustumViewer.ts

@@ -247,32 +247,32 @@ export class DirectionalLightFrustumViewer {
         this._rootNode = new TransformNode("directionalLightHelperRoot_" + this._light.name, this._scene);
         this._rootNode.parent = this._light.parent;
 
-        this._nearLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._nearLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const nearLines = CreateLines("nearlines", { updatable: true, points: this._nearLinesPoints }, this._scene);
         nearLines.parent = this._rootNode;
         nearLines.alwaysSelectAsActiveMesh = true;
 
-        this._farLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._farLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const farLines = CreateLines("farlines", { updatable: true, points: this._farLinesPoints }, this._scene);
         farLines.parent = this._rootNode;
         farLines.alwaysSelectAsActiveMesh = true;
 
-        this._trLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._trLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const trLines = CreateLines("trlines", { updatable: true, points: this._trLinesPoints }, this._scene);
         trLines.parent = this._rootNode;
         trLines.alwaysSelectAsActiveMesh = true;
 
-        this._brLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._brLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const brLines = CreateLines("brlines", { updatable: true, points: this._brLinesPoints }, this._scene);
         brLines.parent = this._rootNode;
         brLines.alwaysSelectAsActiveMesh = true;
 
-        this._tlLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._tlLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const tlLines = CreateLines("tllines", { updatable: true, points: this._tlLinesPoints }, this._scene);
         tlLines.parent = this._rootNode;
         tlLines.alwaysSelectAsActiveMesh = true;
 
-        this._blLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly];
+        this._blLinesPoints = [Vector3.ZeroReadOnly, Vector3.ZeroReadOnly] as Vector3[];
         const blLines = CreateLines("bllines", { updatable: true, points: this._blLinesPoints }, this._scene);
         blLines.parent = this._rootNode;
         blLines.alwaysSelectAsActiveMesh = true;

packages/dev/core/src/DeviceInput/InputDevices/deviceSource.ts

@@ -10,10 +10,10 @@ import type { IKeyboardEvent, IPointerEvent, IWheelEvent } from "../../Events/de
 export type DeviceSourceEvent<T extends DeviceType> = T extends DeviceType.Keyboard
     ? IKeyboardEvent
     : T extends DeviceType.Mouse
-      ? IWheelEvent | IPointerEvent
-      : T extends DeviceType.Touch
-        ? IPointerEvent
-        : never;
+    ? IWheelEvent | IPointerEvent
+    : T extends DeviceType.Touch
+    ? IPointerEvent
+    : never;
 
 /**
  * Class that handles all input for a specific device

packages/dev/core/src/DeviceInput/InputDevices/deviceTypes.ts

@@ -6,13 +6,13 @@ import type { DeviceType, PointerInput, DualShockInput, XboxInput, SwitchInput,
 export type DeviceInput<T extends DeviceType> = T extends DeviceType.Keyboard | DeviceType.Generic
     ? number
     : T extends DeviceType.Mouse | DeviceType.Touch
-      ? Exclude<PointerInput, PointerInput.Move | PointerInput.MouseWheelX | PointerInput.MouseWheelY | PointerInput.MouseWheelZ>
-      : T extends DeviceType.DualShock
-        ? DualShockInput
-        : T extends DeviceType.Xbox
-          ? XboxInput
-          : T extends DeviceType.Switch
-            ? SwitchInput
-            : T extends DeviceType.DualSense
-              ? DualSenseInput
-              : never;
+    ? Exclude<PointerInput, PointerInput.Move | PointerInput.MouseWheelX | PointerInput.MouseWheelY | PointerInput.MouseWheelZ>
+    : T extends DeviceType.DualShock
+    ? DualShockInput
+    : T extends DeviceType.Xbox
+    ? XboxInput
+    : T extends DeviceType.Switch
+    ? SwitchInput
+    : T extends DeviceType.DualSense
+    ? DualSenseInput
+    : never;

packages/dev/core/src/DeviceInput/webDeviceInputSystem.ts

@@ -660,8 +660,8 @@ export class WebDeviceInputSystem implements IDeviceInputSystem {
             "onwheel" in document.createElement("div")
                 ? "wheel" // Modern browsers support "wheel"
                 : (<any>document).onmousewheel !== undefined
-                  ? "mousewheel" // Webkit and IE support at least "mousewheel"
-                  : "DOMMouseScroll"; // let's assume that remaining browsers are older Firefox
+                ? "mousewheel" // Webkit and IE support at least "mousewheel"
+                : "DOMMouseScroll"; // let's assume that remaining browsers are older Firefox
 
         // Code originally in scene.inputManager.ts
         // Chrome reports warning in console if wheel listener doesn't set an explicit passive option.

packages/dev/core/src/Engines/IPipelineContext.ts

@@ -1,6 +1,7 @@
 import type { Nullable } from "../types";
 import type { Effect } from "../Materials/effect";
-import type { IMatrixLike, IVector2Like, IVector3Like, IVector4Like, IColor3Like, IColor4Like, IQuaternionLike } from "../Maths/math.like";
+import type { Color3Like, Color4Like } from "../Maths/math.color";
+import type { MatrixLike, Vector2Like, Vector3Like, Vector4Like, QuaternionLike } from "../Maths/math.vector";
 
 /**
  * Class used to store and describe the pipeline context associated with an effect
@@ -206,7 +207,7 @@ export interface IPipelineContext {
      * @param uniformName Name of the variable.
      * @param matrix matrix to be set.
      */
-    setMatrix(uniformName: string, matrix: IMatrixLike): void;
+    setMatrix(uniformName: string, matrix: MatrixLike): void;
 
     /**
      * Sets a 3x3 matrix on a uniform variable. (Specified as [1,2,3,4,5,6,7,8,9] will result in [1,2,3][4,5,6][7,8,9] matrix)
@@ -234,7 +235,7 @@ export interface IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector2 vector2 to be set.
      */
-    setVector2(uniformName: string, vector2: IVector2Like): void;
+    setVector2(uniformName: string, vector2: Vector2Like): void;
 
     /**
      * Sets a float2 on a uniform variable.
@@ -249,7 +250,7 @@ export interface IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector3 Value to be set.
      */
-    setVector3(uniformName: string, vector3: IVector3Like): void;
+    setVector3(uniformName: string, vector3: Vector3Like): void;
 
     /**
      * Sets a float3 on a uniform variable.
@@ -265,14 +266,14 @@ export interface IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector4 Value to be set.
      */
-    setVector4(uniformName: string, vector4: IVector4Like): void;
+    setVector4(uniformName: string, vector4: Vector4Like): void;
 
     /**
      * Sets a Quaternion on a uniform variable.
      * @param uniformName Name of the variable.
      * @param quaternion Value to be set.
      */
-    setQuaternion(uniformName: string, quaternion: IQuaternionLike): void;
+    setQuaternion(uniformName: string, quaternion: QuaternionLike): void;
 
     /**
      * Sets a float4 on a uniform variable.
@@ -289,20 +290,20 @@ export interface IPipelineContext {
      * @param uniformName Name of the variable.
      * @param color3 Value to be set.
      */
-    setColor3(uniformName: string, color3: IColor3Like): void;
+    setColor3(uniformName: string, color3: Color3Like): void;
 
     /**
      * Sets a Color4 on a uniform variable.
      * @param uniformName Name of the variable.
      * @param color3 Value to be set.
      * @param alpha Alpha value to be set.
      */
-    setColor4(uniformName: string, color3: IColor3Like, alpha: number): void;
+    setColor4(uniformName: string, color3: Color3Like, alpha: number): void;
 
     /**
      * Sets a Color4 on a uniform variable
      * @param uniformName defines the name of the variable
      * @param color4 defines the value to be set
      */
-    setDirectColor4(uniformName: string, color4: IColor4Like): void;
+    setDirectColor4(uniformName: string, color4: Color4Like): void;
 }

packages/dev/core/src/Engines/Native/nativePipelineContext.ts

@@ -1,6 +1,7 @@
 import type { Nullable } from "../../types";
 import type { Effect } from "../../Materials/effect";
-import type { IMatrixLike, IVector2Like, IVector3Like, IVector4Like, IColor3Like, IColor4Like, IQuaternionLike } from "../../Maths/math.like";
+import type { MatrixLike, Vector2Like, Vector3Like, Vector4Like, QuaternionLike } from "../../Maths/math.vector";
+import type { Color3Like, Color4Like } from "../../Maths/math.color";
 import type { IPipelineContext } from "../IPipelineContext";
 import type { NativeEngine } from "../nativeEngine";
 
@@ -95,7 +96,7 @@ export class NativePipelineContext implements IPipelineContext {
     /**
      * @internal
      */
-    public _cacheMatrix(uniformName: string, matrix: IMatrixLike): boolean {
+    public _cacheMatrix(uniformName: string, matrix: MatrixLike): boolean {
         const cache = this._valueCache[uniformName];
         const flag = matrix.updateFlag;
         if (cache !== undefined && cache === flag) {
@@ -493,9 +494,9 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param matrix matrix to be set.
      */
-    public setMatrix(uniformName: string, matrix: IMatrixLike): void {
+    public setMatrix(uniformName: string, matrix: MatrixLike): void {
         if (this._cacheMatrix(uniformName, matrix)) {
-            if (!this._engine.setMatrices(this._uniforms[uniformName]!, matrix.toArray() as Float32Array)) {
+            if (!this._engine.setMatrices(this._uniforms[uniformName]!, matrix.asArray() as Float32Array)) {
                 this._valueCache[uniformName] = null;
             }
         }
@@ -559,7 +560,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector2 vector2 to be set.
      */
-    public setVector2(uniformName: string, vector2: IVector2Like): void {
+    public setVector2(uniformName: string, vector2: Vector2Like): void {
         if (this._cacheFloat2(uniformName, vector2.x, vector2.y)) {
             if (!this._engine.setFloat2(this._uniforms[uniformName]!, vector2.x, vector2.y)) {
                 this._valueCache[uniformName] = null;
@@ -586,7 +587,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector3 Value to be set.
      */
-    public setVector3(uniformName: string, vector3: IVector3Like): void {
+    public setVector3(uniformName: string, vector3: Vector3Like): void {
         if (this._cacheFloat3(uniformName, vector3.x, vector3.y, vector3.z)) {
             if (!this._engine.setFloat3(this._uniforms[uniformName]!, vector3.x, vector3.y, vector3.z)) {
                 this._valueCache[uniformName] = null;
@@ -614,7 +615,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param vector4 Value to be set.
      */
-    public setVector4(uniformName: string, vector4: IVector4Like): void {
+    public setVector4(uniformName: string, vector4: Vector4Like): void {
         if (this._cacheFloat4(uniformName, vector4.x, vector4.y, vector4.z, vector4.w)) {
             if (!this._engine.setFloat4(this._uniforms[uniformName]!, vector4.x, vector4.y, vector4.z, vector4.w)) {
                 this._valueCache[uniformName] = null;
@@ -627,7 +628,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param quaternion Value to be set.
      */
-    public setQuaternion(uniformName: string, quaternion: IQuaternionLike): void {
+    public setQuaternion(uniformName: string, quaternion: QuaternionLike): void {
         if (this._cacheFloat4(uniformName, quaternion.x, quaternion.y, quaternion.z, quaternion.w)) {
             if (!this._engine.setFloat4(this._uniforms[uniformName]!, quaternion.x, quaternion.y, quaternion.z, quaternion.w)) {
                 this._valueCache[uniformName] = null;
@@ -657,7 +658,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param color3 Value to be set.
      */
-    public setColor3(uniformName: string, color3: IColor3Like): void {
+    public setColor3(uniformName: string, color3: Color3Like): void {
         if (this._cacheFloat3(uniformName, color3.r, color3.g, color3.b)) {
             if (!this._engine.setFloat3(this._uniforms[uniformName]!, color3.r, color3.g, color3.b)) {
                 this._valueCache[uniformName] = null;
@@ -671,7 +672,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param color3 Value to be set.
      * @param alpha Alpha value to be set.
      */
-    public setColor4(uniformName: string, color3: IColor3Like, alpha: number): void {
+    public setColor4(uniformName: string, color3: Color3Like, alpha: number): void {
         if (this._cacheFloat4(uniformName, color3.r, color3.g, color3.b, alpha)) {
             if (!this._engine.setFloat4(this._uniforms[uniformName]!, color3.r, color3.g, color3.b, alpha)) {
                 this._valueCache[uniformName] = null;
@@ -684,7 +685,7 @@ export class NativePipelineContext implements IPipelineContext {
      * @param uniformName defines the name of the variable
      * @param color4 defines the value to be set
      */
-    public setDirectColor4(uniformName: string, color4: IColor4Like): void {
+    public setDirectColor4(uniformName: string, color4: Color4Like): void {
         if (this._cacheFloat4(uniformName, color4.r, color4.g, color4.b, color4.a)) {
             if (!this._engine.setFloat4(this._uniforms[uniformName]!, color4.r, color4.g, color4.b, color4.a)) {
                 this._valueCache[uniformName] = null;

packages/dev/core/src/Engines/Processors/shaderCodeNode.ts

@@ -31,8 +31,8 @@ export class ShaderCodeNode {
                     options.isFragment && options.processor?.varyingFragmentKeywordName
                         ? options.processor?.varyingFragmentKeywordName
                         : !options.isFragment && options.processor?.varyingVertexKeywordName
-                          ? options.processor?.varyingVertexKeywordName
-                          : defaultVaryingKeywordName;
+                        ? options.processor?.varyingVertexKeywordName
+                        : defaultVaryingKeywordName;
 
                 if (!options.isFragment && processor.attributeProcessor && this.line.startsWith(attributeKeyword)) {
                     value = processor.attributeProcessor(this.line, preprocessors, options.processingContext);