Merge pull request learningequality#752 from AllanOXDi/Card-fix

fixes card display without a thumbnail
BabyElias · Sep 11, 2024 · 2b03efb · 2b03efb
2 parents dd13ea6 + 8bdfa47
commit 2b03efb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/KCard/BaseCard.vue b/lib/KCard/BaseCard.vue
@@ -183,7 +183,6 @@
     @extend %dropshadow-2dp;
 
     position: relative;
-    display: block;
     text-align: left;
     text-decoration: none;
     list-style-type: none;

diff --git a/lib/KCard/index.vue b/lib/KCard/index.vue
@@ -13,7 +13,10 @@
       <slot name="title"></slot>
     </template>
     <template #default>
-      <div class="thumbnail">
+      <div
+        v-if="thumbnailDisplay !== Thumbnail_Displays.NONE"
+        class="thumbnail"
+      >
         <!-- 
           Render KImg even if thumbnailSrc is not provided since in that case
           KImg takes care of showing the gray placeholder area.
@@ -230,6 +233,11 @@
         default: false,
       },
     },
+    data() {
+      return {
+        Thumbnail_Displays,
+      };
+    },
     computed: {
       rootClass() {
         return this.stylesAndClasses.rootClass;
@@ -418,7 +426,7 @@
   /************* Layout-specific styles *************/
 
   .vertical-with-large-thumbnail {
-    height: 480px; /* (1) */
+    height: auto; /* (1) */
 
     .thumbnail {
       height: 45%;