Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boosteigencompilewithboost146 #49

Merged
merged 3 commits into from
Jan 22, 2014

Conversation

jeffdonahue
Copy link
Contributor

Actually, I wasn't quite able to compile using Boost 1.46 with the previous pull request (whoops) -- had to change boost::random::uniform_real_distribution to boost::uniform_real. When I did compile successfully, I had a bunch of tests failing with 1.46 due to vRngGaussian generating all NaNs. I changed all RNGs to use Boost's "variate_generator" (I think this is the Right Way based on https://svn.boost.org/trac/boost/ticket/904) and this was fixed (compiles and passes all tests in both 1.46 and 1.54).

@Yangqing
Copy link
Member

Boosteigencompilewithboost is a very nice word (is it German?)

Boosteigenkompilewitboosten!

shelhamer added a commit that referenced this pull request Jan 22, 2014
@shelhamer shelhamer merged commit a5f2cb1 into BVLC:boost-eigen Jan 22, 2014
@shelhamer
Copy link
Member

Bestätigt! Fixes #47

@kloudkl
Copy link
Contributor

kloudkl commented Jan 23, 2014

Indeed, in the initial private branch variate_generator was used following the Boost random_demo. Being unaware of the Boost ticket 904, I did not change rodrigob's implementation in commit 1bcdfd4.

As shown in my first comment to #16, I thought "boost::uniform_real is deprecated by uniform_real_distribution" because I installed the most recent version of Boost. But in an open source project especially one that is a uprising popular star like Caffe, compatibility to most of the possible development environments surely should be one of the top priorities for all the user to able to use and contribute to the project without hassles.

Thank you all for this lesson!

@jeffdonahue jeffdonahue deleted the boosteigencompilewithboost146 branch January 28, 2014 22:50
@jeffdonahue jeffdonahue restored the boosteigencompilewithboost146 branch February 4, 2014 20:39
@jeffdonahue jeffdonahue deleted the boosteigencompilewithboost146 branch February 4, 2014 21:22
@jeffdonahue jeffdonahue restored the boosteigencompilewithboost146 branch February 5, 2014 21:33
@jeffdonahue jeffdonahue deleted the boosteigencompilewithboost146 branch February 6, 2014 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants