Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge compression / decompression #85

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Merge compression / decompression #85

merged 4 commits into from
Nov 28, 2022

Conversation

peturhelgi
Copy link
Contributor

  • Add compression and decompression
  • Add command line arguments for compressing and decompressing files
  • Add members to Bustools_opt related to compression
  • Add struct for compressed header
  • Add parsing/writing functions for a compressed header
  • Add other utilities for compression

@peturhelgi peturhelgi requested a review from pmelsted November 28, 2022 11:50
@peturhelgi peturhelgi assigned peturhelgi and unassigned peturhelgi Nov 28, 2022
pmelsted
pmelsted reviewed Nov 28, 2022
View reviewed changes
src/bustools_compress.cpp Outdated
#include "BUSData.h"
#include "bustools_compress.h"

size_t pfd_blocksize = 1024;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passar ekki við default 512 sem er í opt.

pmelsted
pmelsted reviewed Nov 28, 2022
View reviewed changes
src/bustools_decompress.cpp Outdated
#include "BUSData.h"
#include "bustools_compress.h"
#include "bustools_decompress.h"
size_t d_pfd_blocksize = 1024;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

pmelsted
pmelsted requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@pmelsted pmelsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix default pdf_blocksize mismatch between default value in opt and the one in the code.

@peturhelgi peturhelgi requested a review from pmelsted November 28, 2022 13:46
@pmelsted pmelsted merged commit 671f60b into devel Nov 28, 2022
@pmelsted pmelsted deleted the devel_compress branch November 28, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmelsted pmelsted pmelsted approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peturhelgi @pmelsted