Location Checkin, Event population with script, Reformatted Datetime objects, etc. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfirmation occurs in terminal with a check in button
molly-yan
requested changes
Apr 5, 2024
| decoration: BoxDecoration( | ||
| borderRadius: BorderRadius.circular(5), | ||
| color: _currentPage == index ? Colors.blue : Colors.grey.withOpacity(0.5), | ||
| bottom: 10, |
There was a problem hiding this comment.
Use dynamic measurements, instead of magic numbers
There was a problem hiding this comment.
Just made the change + some additional margins for the onboarding page. I think we are good to merge after your approval? The logo images have this weird blue line across it but I think Zihan can upload new logo photos to remove that after
| content: Text("Checked in successfully!"))); | ||
| } else { | ||
| ScaffoldMessenger.of(context).showSnackBar( | ||
| SnackBar(content: Text("Unable to check in: location too far!"))); |
There was a problem hiding this comment.
- Is "location too far" the only false case here, or there might be other possible false cases, such as "Location permission not granted"?
| final List<Event> upcomingEvents = []; | ||
|
|
||
| for (Event event in fetchedEvents) { | ||
| // List<String> splittedTime = event.eventStartTime.split(","); |
|
|
||
| final response = await http.get(requestUrl); | ||
|
|
||
| if (response.statusCode == 200) { |
There was a problem hiding this comment.
Need to include the catch error case
| location_room_address = '' | ||
|
|
||
| try: | ||
| eventRoom = event_detail.find_element(By.XPATH, '//dt[text()="Room:"]/following-sibling::dd').text |
There was a problem hiding this comment.
It's fine for now, but since we might consider using the ICS file provided by IS&T, this method might need to be replaced later.
molly-yan
approved these changes
Apr 10, 2024
| /Users/saisriram/.pub-cache/hosted/pub.dev/cloud_firestore-4.15.6/ |
There was a problem hiding this comment.
Please prevent committing config files for future PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.