Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved issues 135 and 136 #138

Merged
merged 3 commits into from
Oct 29, 2024
Merged

solved issues 135 and 136 #138

merged 3 commits into from
Oct 29, 2024

Conversation

luissian
Copy link
Member

This PR solves the issues:

#135 error page when click on sample
#136 error when upload

Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is not related with the issues in mentioned in this PR. But won't this also fail if the fields are not correct? Just so it can be added as a new issue:

i_sam_proj_data[key]["format"] = item["sampleProjectFieldType"]
if item["sampleProjectFieldType"] == "Options List":
i_sam_proj_data[key]["options"] = []
for opt in item["sampleProjectOptionList"]:
i_sam_proj_data[key]["options"].append(opt["optionValue"])

This was referenced Oct 21, 2024
@luissian
Copy link
Member Author

luissian commented Oct 22, 2024

I am not sure to see your concern about it, The query fields are not set by user in the form but inside the code. Why do you think it could fail?

@saramonzon saramonzon merged commit 3bb297b into BU-ISCIII:develop Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants