Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added permissions fixing after running scratch-copy and implemented a new module #332

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

victor5lm
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

This PR addresses #212.

With the changes implemented in this PR, we make sure that all folders and files copied from scratch to services_and_collaborations have the correct permissions. Furthermore, a fix-permissions module has been added to the tools so that, by providing the absolute path to a folder, all its subfolders and files have the appropriate permissions. This way, when necessary, this module can be ran so that new folders or files have the permissions they should have to avoid any issues.

@victor5lm victor5lm marked this pull request as ready for review September 10, 2024 12:41
bu_isciii/utils.py Outdated Show resolved Hide resolved
bu_isciii/utils.py Outdated Show resolved Hide resolved
bu_isciii/utils.py Outdated Show resolved Hide resolved
bu_isciii/utils.py Outdated Show resolved Hide resolved
@saramonzon
Copy link
Member

Looks really good! Just some comments that i think will improve performance! But check it in any case

@victor5lm victor5lm merged commit 2ddb2f4 into BU-ISCIII:develop Sep 10, 2024
2 checks passed
@victor5lm victor5lm deleted the permissions branch October 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants