Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete template for nf-core/mag pipeline execution #321

Merged
merged 15 commits into from
Sep 5, 2024

Conversation

Daniel-VM
Copy link
Member

@Daniel-VM Daniel-VM commented Aug 23, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

Enhanced the existing template by adding a comprehensive execution framework for the nf-core/mag pipeline. Previously, the template only supported partial execution for taxonomy classification. This update introduces an additional analysis folder, enabling full pipeline runs and expanding the template's functionality for complete metagenomic analysis.

Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Aug 23, 2024
@Daniel-VM Daniel-VM marked this pull request as ready for review September 5, 2024 10:22
@saramonzon
Copy link
Member

LGTM! Just making sure, there no file to add to clean after analysis? Some file pretty big or something we may want to delete?

@Daniel-VM
Copy link
Member Author

There are several *.fa files in fact , but they are not very large. We can test them and add them to the clean section once we have selected tools for each step based on their performance and other factors

@Daniel-VM Daniel-VM merged commit 55968c1 into BU-ISCIII:develop Sep 5, 2024
2 checks passed
Daniel-VM added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants