Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IRMA's lablog so that sequences are not displayed several times #305

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

victor5lm
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

So far, when launching IRMA's lablog, the sequences corresponding to the samples associated with each influenza type were displayed within the .txt files of each type several times, and the same thing happened in all_samples_completo.txt. This is fixed with this PR.

@victor5lm victor5lm marked this pull request as ready for review August 1, 2024 12:55
@victor5lm victor5lm changed the title Fixed IRMA's lablog so that the info is not displayed several times Fixed IRMA's lablog so that sequences are not displayed several times Aug 2, 2024
Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victor5lm victor5lm merged commit a23ef4c into BU-ISCIII:develop Aug 5, 2024
2 checks passed
@victor5lm victor5lm deleted the IRMA_fix branch September 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants