Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipeline documentation and results for mRNAseq #248

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

Daniel-VM
Copy link
Member

@Daniel-VM Daniel-VM commented Apr 23, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

Updated pipeline documentation and results for mRNAseq.

partially BU-ISCIII/BU-ISCIII/issues/70

Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 23, 2024
@Daniel-VM Daniel-VM marked this pull request as ready for review April 23, 2024 15:11
Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 23, 2024
Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 25, 2024
Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 25, 2024
Copy link
Member

@saramonzon saramonzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add pictures to rnaseq.md for each plot
  • Add the files description also to the results_rnaseq.md as they are delivered in the results folder

@Daniel-VM
Copy link
Member Author

* Add the files description also to the results_rnaseq.md as they are delivered in the results folder

Do the description need to be added along with the images to assets/reports/results/rnaseq.md? or only the description?

Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 25, 2024
Daniel-VM added a commit to Daniel-VM/buisciii-tools that referenced this pull request Apr 25, 2024
Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bu_isciii/assets/reports/results/rnaseq.md Outdated Show resolved Hide resolved
bu_isciii/assets/reports/results/rnaseq.md Outdated Show resolved Hide resolved
@saramonzon saramonzon merged commit c3fc7a8 into BU-ISCIII:develop Apr 25, 2024
saramonzon pushed a commit that referenced this pull request Apr 25, 2024
saramonzon pushed a commit that referenced this pull request Apr 25, 2024
juanledesma78 pushed a commit to juanledesma78/buisciii-tools that referenced this pull request Jun 5, 2024
juanledesma78 pushed a commit to juanledesma78/buisciii-tools that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants