Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown of assembly analysis procedure #244

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add markdown of assembly analysis procedure #244

merged 2 commits into from
Apr 23, 2024

Conversation

Daniel-VM
Copy link
Member

@Daniel-VM Daniel-VM commented Apr 23, 2024 •
edited by svarona
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

Added markdown of assembly analysis procedure
(Task accomplished in 47 )

@Daniel-VM Daniel-VM marked this pull request as ready for review April 23, 2024 09:45
svarona
svarona approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svarona svarona merged commit cc932a9 into BU-ISCIII:develop Apr 23, 2024
jaimeozaez
jaimeozaez reviewed Apr 23, 2024
View reviewed changes
bu_isciii/assets/reports/md/assembly.md

## Taxonomic classification

This QC step classifies your reads using [Kraken2](https://ccb.jhu.edu/software/kraken2/) a k-mer based approach. This helps to identify samples that have purity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

102, 103 and 104 are the same line, aren't they?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. I will add this in next PR.

juanledesma78 pushed a commit to juanledesma78/buisciii-tools that referenced this pull request Jun 5, 2024
@Daniel-VM
update changelog in BU-ISCIII#244
242d06f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimeozaez jaimeozaez jaimeozaez left review comments

@svarona svarona svarona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-VM @svarona @jaimeozaez