Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite climb #133

Merged
merged 2 commits into from
Nov 3, 2018
Merged

Fix infinite climb #133

merged 2 commits into from
Nov 3, 2018

Conversation

TomyLobo
Copy link
Collaborator

@TomyLobo TomyLobo commented Oct 4, 2018

There are (depending on the way you count) between 2 and 5 spots for this on da_cocaine.
I also found that this change prevents you from grabbing on to the rails below the roof of the shed on da_megachat. Since this never allowed you to climb anywhere, I think that is acceptable.

Also I made one of the wall angle checks a little less prone to rounding errors, which would have prevented climbing up walls that are almost, but not quite perpendicular to the ground.
One such surface is the side of the big truck on da_cocaine that faces the small truck.

There are client/server dependencies on this one, but they should be minor enough to not matter.

@TomyLobo
Copy link
Collaborator Author

TomyLobo commented Oct 4, 2018

Are you aware of any places where people could (successfully) climb into a crouching position?
I'm not and I don't think it's possible due to the way these traces were always done, so I did not account for those.

@TomyLobo TomyLobo added this to the v1.3.1.0 milestone Oct 5, 2018
@BSVino
Copy link
Owner

BSVino commented Oct 10, 2018

No, but my memory is terrible so you shouldn't count on it. I think I remember testing climb into crouch? Or did I code for it but never test it? Urgh, it was like six years ago ...

@TomyLobo
Copy link
Collaborator Author

heh, well i'm not aware of any.
I'll ask a few stunt-affine people about it if they can think of any.

@TomyLobo TomyLobo merged commit 238db2b into develop Nov 3, 2018
@TomyLobo TomyLobo deleted the fix-infinite-climb branch November 3, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants