Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Exception for missing StoredQueries #230

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

frida-161
Copy link
Contributor

This PR addresses #229.
I added a try block to catch the ows ServiceExceptions that gets thrown, when a WFS does not support the ListStoredQueries method.
To inform the user about the missing StoredQueries, the corresponding tab gets disabled in the UI.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #230 (c350aa7) into master (eb67fe7) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   19.14%   19.12%   -0.03%     
==========================================
  Files          42       42              
  Lines        3703     3708       +5     
  Branches      610      610              
==========================================
  Hits          709      709              
- Misses       2942     2947       +5     
  Partials       52       52              
Impacted Files Coverage Δ
..._application_schema_toolbox/gui/load_wizard_wfs.py 0.00% <0.00%> (ø)

@Guts
Copy link
Collaborator

Guts commented Aug 20, 2022

LGTM!

@Guts Guts merged commit c171380 into BRGM:master Aug 20, 2022
@frida-161 frida-161 deleted the bug/229_differing_urls branch October 20, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants