PauliZGate #254
Merged
PauliZGate #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edyounis
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Hey this is awesome and adds a good amount of features. Thanks for doing this. Besides the inline comments, a few overall thoughts:
- The Pauli and PauliZ classes have the same API, and I can imagine more like it in the future (qudits), it might be worthwhile to extract a base class there with a defined API.
- It should be pretty easy to plug the PauliZGate into QFAST, maybe we can make an example with that. If you improve the performance of the gate unitary and gradient calculation, I could imagine this would rival other synthesis algorithms out there in both performance and quality. If this is important to your application, happy to have a chat about this.
- Can you write a list with the new features in the PR message. This will help me when writing the changelog for the next update. See Surround filter #257 for an example of what I mean.
|
|
||
| def diagonal_distance(unitary: npt.NDArray[np.complex128]) -> float: | ||
| """ | ||
| Compute how diagonal a unitary is. |
There was a problem hiding this comment.
Is there a reference for this?
There was a problem hiding this comment.
There will be soon!
| The DiagonalPredicate class returns True if the circuit's unitary can be | ||
| approximately inverted by a diagonal unitary. A unitary is approximately | ||
| inverted when the Hilbert-Schmidt distance to the identity is less than some | ||
| threshold. |
There was a problem hiding this comment.
Might want to put a "See Also" section in the documentation.
edyounis
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features:
PauliZMatricesclass allows for diagonal Hermitian matrices to be easily specified. Using thePauliMatricesclass results in unwanted overparameterization. The API used is very similar to that forPauliMatrices.PauliZGatelets n-qubit diagonal unitaries be specified in a Circuit.WalshDiagonalSynthesisPass. Outputs are always useCNOTGates andRZGates.[1] https://arxiv.org/abs/1306.3991
[2] https://arxiv.org/abs/2109.03371