Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass down foreach #195

Merged
merged 3 commits into from
Oct 19, 2023
Merged

pass down foreach #195

merged 3 commits into from
Oct 19, 2023

Conversation

mtweiden
Copy link
Contributor

Adding the pass_down_block_specific_key_prefix allows for data specific to individual blocks to be put into a PassData object. The data associated with this prefix must be a mapping between block indices and block specific data.

For example, one may pass block specific seeds with a dictionary in the form
self.pass_down_block_specific_key_prefix + 'seed_circuits' = {block_id: [seed_a, seed_b, ...]}.

@mtweiden mtweiden requested a review from edyounis October 17, 2023 21:01
tests/passes/control/test_foreachblock.py Outdated Show resolved Hide resolved
tests/passes/control/test_foreachblock.py Outdated Show resolved Hide resolved
tests/passes/control/test_foreachblock.py Outdated Show resolved Hide resolved
bqskit/passes/control/foreach.py Outdated Show resolved Hide resolved
Copy link
Member

@edyounis edyounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtweiden mtweiden merged commit 854e4c4 into main Oct 19, 2023
13 checks passed
@mtweiden mtweiden deleted the targeted_foreach branch October 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants