Merge pull request #267 from BQSKit/overflow-fix

Fixed overflow in Unitary.dim

bqskit/qis/unitary/unitary.py

@@ -54,7 +54,14 @@ def dim(self) -> int:
         if hasattr(self, '_dim'):
             return self._dim
 
-        return int(np.prod(self.radixes))
+        # return int(np.prod(self.radixes))
+        # Above line removed due to failure to handle overflow and
+        # underflows for large dimensions.
+
+        acm = 1
+        for radix in self.radixes:
+            acm *= int(radix)
+        return acm
 
     @abc.abstractmethod
     def get_unitary(self, params: RealVector = []) -> UnitaryMatrix:

tests/qis/unitary/test_props.py

@@ -0,0 +1,8 @@
+from __future__ import annotations
+
+from bqskit.ir.circuit import Circuit
+
+
+def test_circuit_dim_overflow() -> None:
+    c = Circuit(1024)
+    assert c.dim != 0