Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Anchor consensus-only data (remove txid) #84

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

dr-orlovsky
Copy link
Member

This is the alternative to #83 removing non-consensus data from Anchors and achieving the same goal by just delegating SPV storage and verification outside of this library.

@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) *scalability* Issues affecting system scalability refactoring Refactoring of the existing code labels Mar 30, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 30, 2024
@dr-orlovsky dr-orlovsky self-assigned this Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.7%. Comparing base (7b1ff00) to head (c014bad).

Files Patch % Lines
seals/src/txout/witness.rs 0.0% 3 Missing ⚠️
dbc/src/anchor.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #84     +/-   ##
========================================
- Coverage    48.2%   47.7%   -0.5%     
========================================
  Files          36      34      -2     
  Lines        3290    3149    -141     
========================================
- Hits         1587    1503     -84     
+ Misses       1703    1646     -57     
Flag Coverage Δ
rust 47.7% <60.0%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit 95f0ad8 into master Apr 18, 2024
20 checks passed
@dr-orlovsky dr-orlovsky deleted the deanchor branch September 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code *scalability* Issues affecting system scalability *security* Issues affecting safety/security (include undefined behaviours)
Projects
Development

Successfully merging this pull request may close these issues.

1 participant