Disabling external libraries #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix causes two libraries to be built without including two external libraries that get found when already installed on the Mac by Homebrew for example.
|
@CharlieFenton - are you able to review this pull request? |
|
@ShanghaiTimes: Thank you and welcome to BOINC development and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch causes two libraries to be built without including two external libraries that get found when already installed on the Mac by other software builds.
Fixes #
Description of the Change
Building on a Mac that has libraries installed that are identical or similar to BOINC required libraries, will be found by the BOINC build. These two changes disable two such libraries. nghttp2 and png respectively found by buildcurl.sh and buildfreetype.sh.
Alternate Designs
It became impossible to cleanly build these two components with the external version libraries included in the build.
Release Notes
On OSX 10.14.3
buildcurl.sh --without-nghttp2
buildfreetype.sh --without-png