Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip HTML tags for the page title #2980

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Strip HTML tags for the page title #2980

merged 1 commit into from
Feb 2, 2019

Conversation

sergeyklay
Copy link
Contributor

Description of the Change
Strip HTML tags for the page title.

Screenshots
image

Release Notes

  • Fixed title for the pages that were subject to localization

@davidpanderson
Copy link
Contributor

Let's fix this by changing the call to page_head() in team_members.php.
That's the only call that passes HTML.

@sergeyklay
Copy link
Contributor Author

@davidpanderson It is not so correct because the page_head() function calls the project_banner() . So this will remove the link to a team. Please take a look at project_banner function:

if ($title) {
echo "<h2>$title</h2>\n";
}

@sergeyklay
Copy link
Contributor Author

@davidpanderson Should I leave it as is or change the call to page_head() in team_members.php instead?

@davidpanderson
Copy link
Contributor

Please make that change.

@sergeyklay
Copy link
Contributor Author

Done

@ChristianBeer ChristianBeer merged commit 902833b into BOINC:master Feb 2, 2019
@sergeyklay sergeyklay deleted the fix/strip-title-for-the-teams branch February 2, 2019 21:59
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants