Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client, Win: append .exe to service process program name if missing #2036

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Client, Win: append .exe to service process program name if missing #2036

merged 2 commits into from
Aug 16, 2017

Conversation

davidpanderson
Copy link
Contributor

No description provided.

@AenBleidd
Copy link
Member

@davidpanderson Maybe it's better and safer to use std::string instead of char array?

@davidpanderson
Copy link
Contributor Author

Yes, but in practice 1023 is plenty.

When I write new code I use std::string, but I'm not sure it's worth converting
all the char arrays, as long as we use size-aware functions like strlcat().

@AenBleidd
Copy link
Member

OK

@Ageless93 Ageless93 mentioned this pull request Aug 15, 2017
Closed
@davidpanderson
client: hardware client executable name: boinc or boinc.exe
12d1391 
The GPU detection code was already doing this;
do for Win daemon process startup as well.
@davidpanderson davidpanderson merged commit d7a38ca into master Aug 16, 2017
@davidpanderson davidpanderson deleted the win_exe branch September 28, 2017 04:30
@RichardHaselgrove RichardHaselgrove mentioned this pull request Aug 24, 2018
Closed
@davidpanderson davidpanderson restored the win_exe branch July 30, 2019 01:46
@davidpanderson davidpanderson deleted the win_exe branch July 30, 2019 01:57
@davidpanderson davidpanderson restored the win_exe branch August 13, 2019 13:52
@AenBleidd AenBleidd deleted the win_exe branch September 24, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpanderson @AenBleidd