For issue mozilla-mobile#10725 - Truncated account details

- Set the textview's height to "wrap_content" and added top/bottom padding to account for the size difference and maintain the original height
BMEduard · May 28, 2020 · 95bcc5d · 95bcc5d
1 parent fe3a67a
commit 95bcc5d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/src/main/res/layout/fragment_login_detail.xml b/app/src/main/res/layout/fragment_login_detail.xml
@@ -33,10 +33,12 @@
     <TextView
         android:id="@+id/webAddressText"
         android:layout_width="0dp"
-        android:layout_height="30dp"
+        android:layout_height="wrap_content"
         android:gravity="center_vertical"
         android:textColor="?primaryText"
         android:textSize="16sp"
+        android:paddingTop="@dimen/saved_logins_detail_menu_vertical_padding"
+        android:paddingBottom="@dimen/saved_logins_detail_menu_vertical_padding"
         app:layout_constraintEnd_toEndOf="@id/webAddressHeader"
         app:layout_constraintStart_toStartOf="@id/webAddressHeader"
         app:layout_constraintTop_toBottomOf="@id/webAddressHeader"
@@ -75,11 +77,13 @@
     <TextView
         android:id="@+id/usernameText"
         android:layout_width="0dp"
-        android:layout_height="30dp"
+        android:layout_height="wrap_content"
         android:gravity="center_vertical"
         android:textColor="?primaryText"
         android:textSize="16sp"
         android:layout_marginTop="1dp"
+        android:paddingTop="@dimen/saved_logins_detail_menu_vertical_padding"
+        android:paddingBottom="@dimen/saved_logins_detail_menu_vertical_padding"
         app:layout_constraintEnd_toEndOf="@id/usernameHeader"
         app:layout_constraintStart_toStartOf="@id/usernameHeader"
         app:layout_constraintTop_toBottomOf="@id/usernameHeader"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -152,5 +152,6 @@
     <!-- Saved Logins Fragment -->
     <dimen name="saved_logins_sort_menu_dropdown_chevron_icon_margin_start">10dp</dimen>
     <dimen name="saved_logins_sort_menu_dropdown_chevron_icon_size">12dp</dimen>
+    <dimen name="saved_logins_detail_menu_vertical_padding">5dp</dimen>
 
 </resources>