Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hostname when dynoid not provided #316

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

mestachs
Copy link
Collaborator

Self proof reading checklist

  • Did I run Pronto and fixed all warnings (pronto run -c origin/dev)
  • Make sure all naming and code will remain understandable in 6 month by someone new to the project or by you.
  • Did I test the right thing?
  • Did I test corner cases, non happy path (defensive testing)?
  • Check that I used the ad-hoc patterns and created files accordingly (Presenters, Services, Search object, Form object,...)
  • Check code efficiency with record intensive project
  • Update documentation,readme accordingly

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant