Rails upgrade 7.0.4.1 and ruby 3.2.0 #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaspers
approved these changes
Jan 24, 2023
| @@ -394,7 +394,7 @@ def changelog(other_project = original) | |||
|
|
|||
| diff_symbols = { "+" => :added, "-" => :removed, "~" => :modified } | |||
| all_names = to_unified_names.merge(other_project.to_unified_names) | |||
| HashDiff.diff(other_project.to_unified_h, to_unified_h).map do |hash_diff| | |||
| Hashdiff.diff(other_project.to_unified_h, to_unified_h).map do |hash_diff| | |||
There was a problem hiding this comment.
it's weird yes, as if the gem changed it afterwards
https://github.com/liufengyun/hashdiff#diff or it's another gem ?
| @@ -75,8 +76,8 @@ def package_formula_uniqness | |||
| formula_by_codes.each do |code, formulas| | |||
| next unless formulas.size > 1 | |||
|
|
|||
| rule.errors[:formulas] << "Formula's code must be unique,"\ | |||
| " you have #{formulas.size} formulas with '#{code}'" | |||
| rule.errors.add(:formulas, "Formula's code must be unique,"\ | |||
There was a problem hiding this comment.
I'll miss the << for errors
| @@ -32,12 +32,12 @@ | |||
| class InvoicingJobSerializer | |||
| include FastJsonapi::ObjectSerializer | |||
| set_key_transform :camel_lower | |||
| attribute :org_unit, &:orgunit_ref | |||
| attribute :org_unit do |rec| rec.orgunit_ref end | |||
There was a problem hiding this comment.
I would have gone { } for the single line thing, but this words as well, they don't allow a proc anymore?
| @@ -3,6 +3,8 @@ | |||
| <head> | |||
| <title>Open RBF 2.0</title> | |||
| <%= csrf_meta_tags %> | |||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.15.4/css/solid.css" integrity="sha384-Tv5i09RULyHKMwX0E8wJUqSOaXlyu3SQxORObAI08iUwIalMmN5L6AvlPX2LMoSE" crossorigin="anonymous"/> | |||
There was a problem hiding this comment.
Might be worth it to just download it, and serve it ourselves.
| @@ -3,6 +3,7 @@ | |||
| end | |||
|
|
|||
| RailsAdmin.config do |config| | |||
| config.asset_source = :sprockets | |||
There was a problem hiding this comment.
This feels like a line that looks simple but hides a lot of hair pulling.
|
liufengyun/hashdiff@3a8ce95
So looks to be intentional :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion PR : BLSQ/orbf-rules_engine#91
errors[:myfield] << "my error message"vserrors.add(:myfield, "my error message")update_attributesis gone