SLEEP-1499 Support embedding of Superset dashboard in Iaso #1698
+184
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new pages template that supports embedding a new type of page "SUPERSET" - Add an API endpoint POST /api/superset/token that creates a Superset "guest token" for a specific dashboard
madewulf
reviewed
Oct 17, 2024
| SERVER_URL: | ||
| SUPERSET_DB_NAME: | ||
| SUPERSET_DB_HOSTNAME: | ||
| SUPERSET_DB_PASSWORD: |
madewulf
reviewed
Oct 17, 2024
| <head> | ||
| <title>{{title}}</title> | ||
| {{ analytics_script | safe }} | ||
| <script src="https://unpkg.com/@superset-ui/embedded-sdk"></script> |
There was a problem hiding this comment.
Ideally, we should have this copied in our code base and not depending on an external source
madewulf
reviewed
Oct 17, 2024
|
|
||
| supersetEmbeddedSdk.embedDashboard({ | ||
| id: '{{dashboard_id}}', | ||
| supersetDomain: 'https://superset.trypelim.org', |
madewulf
reviewed
Oct 17, 2024
| </head> | ||
|
|
||
| <body> | ||
| <div id="my-superset-container"></div> |
There was a problem hiding this comment.
Not very important, but why "my" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a v1 for embedding Superset dashboards in Iaso, using the
Pagesmodel.Specifically:
/api/superset/tokenthat creates a Superset "guest token" for a specific dashboardRelated JIRA tickets : https://bluesquare.atlassian.net/browse/SLEEP-1499
Note that this is a v1. In order to make this properly usable for regular users, I think we should have a place where you can configure the connection to such a dashboard for a given account.
Doc
No docs yet since it's not really publicly usable yet. Like PowerBI, we can enable it by setting the page type to "Superset" via the admin, but not just any user can activate it since it requires ENV vars to be configured to a Superset server.
How to test
dashboard_id.dashboard_idyou want to embed.