IA-3456 improve get or create for orgunit (duplicate on uuid) #1661
+80
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mestachs
changed the title
bramj
reviewed
Oct 8, 2024
| @@ -686,6 +686,7 @@ def instance_logs(self, request, pk=None, logId=None): | |||
|
|
|||
| def import_data(instances, user, app_id): | |||
| project = Project.objects.get_for_user_and_app_id(user, app_id) | |||
| default_version = project.account.default_version | |||
There was a problem hiding this comment.
I think it's possible to not have a default version on an account. I think that situation would probably blow up anyways, but not sure if we should consider it here 🤔
There was a problem hiding this comment.
@beygorghor I think we already had to code special cases when there is no default_version so it can happen right ?
There was a problem hiding this comment.
Yes indeed, the frontend allows no default version
| def import_data(org_units, user, app_id): | ||
| new_org_units = [] | ||
| project = Project.objects.get_for_user_and_app_id(user, app_id) | ||
| org_units = sorted(org_units, key=get_timestamp) | ||
|
|
||
| project = Project.objects.get_for_user_and_app_id(user, app_id) |
mathvdh
reviewed
Oct 8, 2024
| @@ -686,6 +686,7 @@ def instance_logs(self, request, pk=None, logId=None): | |||
|
|
|||
| def import_data(instances, user, app_id): | |||
| project = Project.objects.get_for_user_and_app_id(user, app_id) | |||
| default_version = project.account.default_version | |||
There was a problem hiding this comment.
@beygorghor I think we already had to code special cases when there is no default_version so it can happen right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minize duplicate and be "ready" when we will introduce the unique index
Related JIRA tickets : IA-3456
Self proofreading checklist
Doc
Changes
see #1652
How to test
see #1652
but the mobile unit test does that
for a more "real life" reproduction : https://gist.github.com/mestachs/2cc50bf310996d14cc48623a05d42caf
note that we have historical data so we will need an intermediate cleanup
create the a temporary index as in the _notes.md
then really cleanup "old data" and all environments (harder)
Print screen / video
Upload here print screens or videos showing the changes
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here