Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-2339] Fixing locally failing test - empty geom #1489

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tdethier
Copy link
Member

@tdethier tdethier commented Jul 17, 2024

Fixes the empty geom unit test both locally and on the CI.

Related JIRA tickets : IA-2339

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Long thread on Slack explaining what I tried to do in order to solve this: https://bluesquare.slack.com/archives/C032F8GFAUD/p1721726253767399

Changes

  • Upgraded the CI Ubuntu version
  • Fixed the unit code test

How to test

  • Launch tests locally
  • Check the CI in this PR

Print screen / video

/

Notes

/

@tdethier tdethier marked this pull request as ready for review July 17, 2024 13:55
@tdethier tdethier changed the title Trying to fix locally failing test [IA-23339] Fixing locally failing test - empty geom Sep 19, 2024
@tdethier
Copy link
Member Author

tdethier commented Sep 19, 2024

I'll do some cleanup before any merge (right after taking care of OUCRCs).
Also, if we upgrade the Ubuntu version, it should be done for all 3 jobs, not just the test_python one

@tdethier tdethier changed the title [IA-23339] Fixing locally failing test - empty geom [IA-2339] Fixing locally failing test - empty geom Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant