Write API usage cache on every successful poll #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a new install, should the API call to get usage and limit fail for the very first time then the cache will not yet be created. Prior, the limit would have been zero, causing all sorts of issues. This sets the default to ten.
BJReplay
approved these changes
Jun 16, 2024
|
Absolutely agree. This was a super simple one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of API calls used is retrieved from Solcast on integration restart. If this fails (due to site busy), then the usage cache is relied on to know how many calls have been made for the day.
This cache is not being updated when successful calls to get solar forecast are made, so this pull fixes that.
Thanks for pointing this out, @gcoan. #12.