Removed hard-coded paths and provided instructions on running on mac #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about usability. It was an arduous task to be able to run the KMeansLearner.ssc script. This PR aims to make it (a) possible to do so (the code has hardcoded paths so is unworkable without these changes) and (b) provides more guidance on how to achieve it. These are applicable to all platforms.
Finally there are details specifically related to Mac.
Here is an excerpt from the Update README.md that shows the changes to the script files to make them usable outside of the specific AWS machine and directory structure that the original developer was using:
System properties to control the testing scripts
The .ssc files under scripts/ directory are used to test the installation. Here are environment variables / System properties to configure them properly for your local environment: