6.3 Deployment

[bhombot-ci]

XML_Toolkit

Feature

• Specify the file that couldn't be pulled on pull error

Bug

• Fix read and write of generic XML if they are BHoMObjects

Compliance

• Fix project compliance
• Remove GBXML DocumentBuilder from workflow for pushing Environment objects to XML
• Update AssemblyFileVersion to 6.3
• Upgrade XML Toolkit to NetStandard 2.0

Uncategorised

• Remove 6.2 PreviousVersion Attributes

[CKBoulter]

Tested using BHoM_6.3.230914.beta.0 and the Environment's XML_Toolkit testing procedure
and scripts from Alpha's XML Toolkit.

The model pulls through correctly, however, the procedure documents and scripts are outdated. Therefore, after agreement, it is given a PASS but updates to the procedure document and scripts are needed.

[albinber]

@BHoMBot check compliance

[bhombot-ci]

@albinber to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 118 requests in the queue ahead of you.

[alelom]

Performed tests according to XML_Toolkit test procedure only once and with the 230915 6.3 installer. Tests did not pass. Communicated this to @FraserGreenroyd on 15/09, who mentioned fixing work was in progress. If required I'm happy to test again.

Test results:

1.0 Pulling a Generic file into BHoM:

			1. Error occurred while deserialising the XML to object of type . Error received was: System.ArgumentNullException: Value cannot be null.
		Parameter name: type
		   at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, String defaultNamespace, String location, Evidence evidence)
		   at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides)
		   at BH.Adapter.XML.XMLAdapter.ReadDefault(Type type, XMLConfig config).

2.0 Pushing BHoM objects to a generic XML file:

	1. Error serialising objects to XML. Error received: System.InvalidOperationException: There was an error reflecting type 'BH.oM.Environment.Elements.Panel'. ---> System.InvalidOperationException: There was an error reflecting property 'ExternalEdges'. ---> System.InvalidOperationException: There was an error reflecting type 'BH.oM.Environment.Elements.Edge'. ---> System.InvalidOperationException: Cannot serialize member 'BH.oM.Environment.Elements.Edge.Curve' of type 'BH.oM.Geometry.ICurve', see inner exception for more details. ---> System.NotSupportedException: Cannot serialize member BH.oM.Environment.Elements.Edge.Curve of type BH.oM.Geometry.ICurve because it is an interface.
		   --- End of inner exception stack trace ---
		   at System.Xml.Serialization.StructModel.CheckSupportedMember(TypeDesc typeDesc, MemberInfo member, Type type)
		   at System.Xml.Serialization.StructModel.GetPropertyModel(PropertyInfo propertyInfo)
		   at System.Xml.Serialization.StructModel.GetFieldModel(MemberInfo memberInfo)
		   at System.Xml.Serialization.XmlReflectionImporter.InitializeStructMembers(StructMapping mapping, StructModel model, Boolean openModel, String typeName, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportStructLikeMapping(StructModel model, String ns, Boolean openModel, XmlAttributes a, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel model, String ns, ImportContext context, String dataType, XmlAttributes a, Boolean repeats, Boolean openModel, RecursionLimiter limiter)
		   --- End of inner exception stack trace ---
		   at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel model, String ns, ImportContext context, String dataType, XmlAttributes a, Boolean repeats, Boolean openModel, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.CreateArrayElementsFromAttributes(ArrayMapping arrayMapping, XmlArrayItemAttributes attributes, Type arrayElementType, String arrayElementNs, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportArrayLikeMapping(ArrayModel model, String ns, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportAccessorMapping(MemberMapping accessor, FieldModel model, XmlAttributes a, String ns, Type choiceIdentifierType, Boolean rpc, Boolean openModel, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportFieldMapping(StructModel parent, FieldModel model, XmlAttributes a, String ns, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.InitializeStructMembers(StructMapping mapping, StructModel model, Boolean openModel, String typeName, RecursionLimiter limiter)
		   --- End of inner exception stack trace ---
		   at System.Xml.Serialization.XmlReflectionImporter.InitializeStructMembers(StructMapping mapping, StructModel model, Boolean openModel, String typeName, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportStructLikeMapping(StructModel model, String ns, Boolean openModel, XmlAttributes a, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel model, String ns, ImportContext context, String dataType, XmlAttributes a, Boolean repeats, Boolean openModel, RecursionLimiter limiter)
		   --- End of inner exception stack trace ---
		   at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(TypeModel model, String ns, ImportContext context, String dataType, XmlAttributes a, Boolean repeats, Boolean openModel, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportElement(TypeModel model, XmlRootAttribute root, String defaultNamespace, RecursionLimiter limiter)
		   at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(Type type, XmlRootAttribute root, String defaultNamespace)
		   at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, String defaultNamespace, String location, Evidence evidence)
		   at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides)
		   at BH.Adapter.XML.XMLAdapter.CreateDefault[T](IEnumerable`1 objects, XMLConfig config).

[bhombot-ci]

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on ETABS_Toolkit

[bhombot-ci]

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check null-handling
• check serialisation

There are 42 requests in the queue ahead of you.

[bhombot-ci]

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

[FraserGreenroyd]

PR Checked by DevOps following Testing Sprint. Everything is satisfactory, DevOps clear to merge.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.