Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Construction push bug #354

Conversation

MajaLindroth
Copy link
Contributor

Closes #342

Added "return null" if the input construction is set to null. Making it possible to push even with null construction.

@FraserGreenroyd FraserGreenroyd changed the title XML_Toolkit #342 includeCunstructions Fix Construction push bug Sep 24, 2019
@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Sep 24, 2019
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MajaLindroth 😄

@FraserGreenroyd FraserGreenroyd merged commit d44dc30 into BHoM:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML_Toolkit: bug XMLSettings includeConstructions
2 participants