Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references for compliance #350

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Update references for compliance #350

merged 1 commit into from
Sep 18, 2019

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #349

Test files

N/A read files changed

Changelog

  • Updated Code Compliance of XML_Engine.csproj
  • Updated Code Compliance of XML_Adapter.csproj

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 17, 2019
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 17, 2019
michaldengusiak
michaldengusiak approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,
export valid gbXML
image

@FraserGreenroyd FraserGreenroyd merged commit 173e398 into master Sep 18, 2019
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#349-Refs branch September 18, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldengusiak michaldengusiak michaldengusiak approved these changes

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML_Toolkit: Fix references to other DLLs
2 participants
@FraserGreenroyd @michaldengusiak