Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to Level from Architecture to Geometry.SettingOut #347

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

al-fisher
Copy link
Member

NOTE: Depends on

BHoM/BHoM#554
BHoM/BHoM_Engine#1204

Issues addressed by this PR

Closes #346

Additional comments

  • Dependencies on Architecture.Elements.Level removed and replaced with Geometry.SettingOut.Level
  • External Create DocumentBuilder based on List<BH.oM.Architecture.Elements.Level> levels deprecated.

@al-fisher al-fisher added severity:low Doesn't stop/slow current workflow status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:compliance Non-conforming to code guidelines labels Sep 14, 2019
@al-fisher al-fisher self-assigned this Sep 14, 2019
@FraserGreenroyd FraserGreenroyd removed the request for review from michaldengusiak September 14, 2019 06:28
@michaldengusiak michaldengusiak self-requested a review September 14, 2019 20:18
@FraserGreenroyd FraserGreenroyd removed the request for review from michaldengusiak September 14, 2019 20:21
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported gbXML - pass
image

@al-fisher al-fisher merged commit ee46ca3 into master Sep 18, 2019
@al-fisher al-fisher deleted the BHoM-#536-MigrateGridsFromArchitectureToGeometry branch September 18, 2019 12:09
@al-fisher al-fisher removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating deprecated Architecture Levels to Geometry.SettingOut Levels
3 participants