Clean Polyline #337
Merged
Clean Polyline #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested changes
Aug 15, 2019
There was a problem hiding this comment.
LGTM on the most part, however, I'm not a fan of the hard coded tolerance set at 0.01. I suspect it's useful for the project test files but may not be useful for all projects.
I would recommend including it on the XMLSettings and using that to allow users to specify what their distanceTolerance is going to be. If that can be changed to that I'd be happier 😄
FraserGreenroyd
requested changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
This PR increases accuracy from 99.0% to 99.8%
Fixes #336
Test files
test file
Changelog
Adjust clean polyline
Additional comments