Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML_Toolkit: Add protection if directory does not exist #332

Merged
merged 1 commit into from
Aug 1, 2019
Merged

XML_Toolkit: Add protection if directory does not exist #332

merged 1 commit into from
Aug 1, 2019

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #331

Test files

Existing scripts

Changelog

  • Added protection if the FileSettings directory does not exist.

@FraserGreenroyd FraserGreenroyd added the size:XS Measured in seconds label Aug 1, 2019
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 1, 2019
mariatjader
mariatjader approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@mariatjader mariatjader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push/Pull functionality and if savepath was wrong, the file was saved at desktop.

@FraserGreenroyd FraserGreenroyd merged commit 0d3d940 into master Aug 1, 2019
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-Issue331 branch August 1, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariatjader mariatjader mariatjader approved these changes

@vbeardow vbeardow Awaiting requested review from vbeardow

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
size:XS Measured in seconds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML_Toolkit: Add warning if directory does not exist
2 participants
@FraserGreenroyd @mariatjader