Fix read and write of generic XML

BHoM · Sep 11, 2023 · 699a2e0 · 699a2e0
1 parent 6470096
commit 699a2e0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/XML_Adapter/CRUD/Default/CreateDefault.cs b/XML_Adapter/CRUD/Default/CreateDefault.cs
@@ -58,8 +58,12 @@ private bool CreateDefault<T>(IEnumerable<T> objects, XMLConfig config)
                 foreach (System.Reflection.PropertyInfo pi in bhomProperties)
                     overrides.Add(typeof(BHoMObject), pi.Name, new XmlAttributes { XmlIgnore = true });
 
+                var exportType = typeof(T);
+                if (exportType == typeof(IBHoMObject))
+                    exportType = objects.First().GetType();
+
                 XmlSerializerNamespaces xns = new XmlSerializerNamespaces();
-                XmlSerializer szer = new XmlSerializer(typeof(T), overrides);
+                XmlSerializer szer = new XmlSerializer(exportType, overrides);
                 TextWriter ms = new StreamWriter(_fileSettings.GetFullFileName());
                 foreach (var obj in objects)
                 {

diff --git a/XML_Adapter/CRUD/Default/ReadDefault.cs b/XML_Adapter/CRUD/Default/ReadDefault.cs
@@ -54,8 +54,14 @@ private IEnumerable<IBHoMObject> ReadDefault(Type type = null, XMLConfig config
             object obj = null;
             try
             {
+                System.Reflection.PropertyInfo[] bhomProperties = typeof(BHoMObject).GetProperties();
+                XmlAttributeOverrides overrides = new XmlAttributeOverrides();
+
+                foreach (System.Reflection.PropertyInfo pi in bhomProperties)
+                    overrides.Add(typeof(BHoMObject), pi.Name, new XmlAttributes { XmlIgnore = true });
+
                 TextReader reader = new StreamReader(_fileSettings.GetFullFileName());
-                XmlSerializer szer = new XmlSerializer(type);
+                XmlSerializer szer = new XmlSerializer(type, overrides);
                 obj = System.Convert.ChangeType(szer.Deserialize(reader), type);
                 reader.Close();
             }